fix: useFundCardSetupOnrampEventListeners unmount reset #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@teimurjan is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
dgca
reviewed
Apr 21, 2025
packages/onchainkit/src/fund/hooks/useFundCardSetupOnrampEventListeners.ts
Show resolved
Hide resolved
dgca
requested changes
Apr 21, 2025
dgca
reviewed
Apr 23, 2025
packages/onchainkit/src/fund/hooks/useFundCardSetupOnrampEventListeners.ts
Show resolved
Hide resolved
|
@teimurjan Heyo, sorry for all the back and forth but now it looks like the test coverage is under 100%. We need it at 100% to merge. Btw, you can check that locally by doing |
teimurjan
force-pushed
the
fix-fund-card-listener-unmount-reset
branch
from
5a1d5ba to
bf22ac4
Compare
I get it. I've just committed a fix with a new test checking the missing lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated cleanup of useFundCardSetupOnrampEventListeners on unmount. Currently, if the provider unmounts within 3000ms after an action, state mutation happens on an unmounted provider.
Notes to reviewers
How has it been tested?