Skip to content

feat: Support CLI option to setup ai editor rules #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

xtbase
Copy link
Contributor

@xtbase xtbase commented Apr 22, 2025

What changed? Why?

  • Adding prompt for CLI to provide some default rules for popular ai powered editors
Screen.Recording.2025-04-22.at.11.56.55.AM.mov

Notes to reviewers

How has it been tested?

pnpm test

Copy link

vercel bot commented Apr 22, 2025

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 9:23pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 9:23pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 9:23pm

@xtbase
Copy link
Contributor Author

xtbase commented Apr 23, 2025

@dgca updated ty

- Follow frame security best practices

Best Practices
- Always wrap components with OnchainKitProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: I don't think this is right 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pulled from current rule

https://cursor.directory/onchainkit

we should update this if we want more accurate rules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think updating those rules should happen before we merge this PR.

I don't think we should include rules that tell OnchainKit to do things incorrectly.

Alternatively, we can make the content in the codebase the source of truth, and update https://cursor.directory/onchainkit afterwards. I don't have a preference on order of operations, but I think we should figure out how we wanna do that before merging this PR

@xtbase
Copy link
Contributor Author

xtbase commented Apr 23, 2025

Updated @dgca I think regarding the exact rules we can even pull that from some remote place later on so it's more dynamic , this should be fine for now wdyt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants