-
Notifications
You must be signed in to change notification settings - Fork 329
feat: Support CLI option to setup ai editor rules #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Auster Chen <[email protected]>
Signed-off-by: Auster Chen <[email protected]>
@dgca updated ty |
- Follow frame security best practices | ||
|
||
Best Practices | ||
- Always wrap components with OnchainKitProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: I don't think this is right 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pulled from current rule
https://cursor.directory/onchainkit
we should update this if we want more accurate rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, I think updating those rules should happen before we merge this PR.
I don't think we should include rules that tell OnchainKit to do things incorrectly.
Alternatively, we can make the content in the codebase the source of truth, and update https://cursor.directory/onchainkit afterwards. I don't have a preference on order of operations, but I think we should figure out how we wanna do that before merging this PR
Updated @dgca I think regarding the exact rules we can even pull that from some remote place later on so it's more dynamic , this should be fine for now wdyt |
What changed? Why?
Screen.Recording.2025-04-22.at.11.56.55.AM.mov
Notes to reviewers
How has it been tested?
pnpm test