Skip to content

chore: Add Storybook MVP #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Add Storybook MVP #2366

wants to merge 3 commits into from

Conversation

dgca
Copy link
Contributor

@dgca dgca commented May 16, 2025

What changed? Why?

Adds Storybook and a couple of demo stories to test out Chromatic and upcoming docs migration support

Notes to reviewers

Styling doesn't work at the moment. Two options for how to fix:

  1. We can change the base branch of chore: Prefix component classnames #2310 to main. That will switch our Tailwind setup to use Vite. This will be a breaking change, but will actually unblock a couple teams who have asked for this.
  2. We can set up Postcss to compile Tailwind styles. This will be more work, but wouldn't require breaking changes.

How has it been tested?

Manually

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 9:22pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 9:22pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 9:22pm

@cb-heimdall
Copy link

cb-heimdall commented May 16, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants