Skip to content

Update and clean packages#126

Merged
amiecorso merged 3 commits intocoinbase:mainfrom
shamit05:shamit/add-packages
Sep 11, 2025
Merged

Update and clean packages#126
amiecorso merged 3 commits intocoinbase:mainfrom
shamit05:shamit/add-packages

Conversation

@shamit05
Copy link
Copy Markdown
Contributor

@shamit05 shamit05 commented Sep 10, 2025 •
edited
Loading

Created lock file and updated snapshots and remappings. Generated forge snapshots using FOUNDRY_PROFILE=deploy forge snapshot

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Sep 10, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@shamit05 shamit05 marked this pull request as ready for review September 10, 2025 21:57
@amiecorso amiecorso self-requested a review September 10, 2025 22:07
amiecorso
amiecorso approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amiecorso amiecorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep you can commit the lockfile! I think foundry lock files are only automatic as of relatively new versions of foundry, which is why, I believe, it doesn't already exist in this repo.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Sep 10, 2025

Review Error for amiecorso @ 2025-09-10 22:09:11 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@amiecorso amiecorso self-requested a review September 10, 2025 22:09
amiecorso
amiecorso previously approved these changes Sep 10, 2025
View reviewed changes
@shamit05 shamit05 changed the title Added uniswap Update and clean packages Sep 10, 2025
@shamit05 shamit05 requested a review from amiecorso September 10, 2025 22:28
@shamit05
Copy link
Copy Markdown
Contributor Author

shamit05 commented Sep 10, 2025

snapshots created using FOUNDRY_PROFILE=deploy forge snapshot

@amiecorso amiecorso merged commit 022b87b into coinbase:main Sep 11, 2025
6 of 10 checks passed
Dark-Brain07 pushed a commit to Dark-Brain07/smart-wallet that referenced this pull request Feb 14, 2026
@shamit05 @Dark-Brain07
Update and clean packages (coinbase#126)
da03e9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amiecorso amiecorso amiecorso approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shamit05 @cb-heimdall @amiecorso