feat: E2E gas profiling native and erc20#127
Merged
amiecorso merged 2 commits intocoinbase:mainfrom Sep 11, 2025
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
amiecorso
reviewed
Sep 11, 2025
amiecorso
reviewed
Sep 11, 2025
test/gas/EndToEnd.t.sol
Outdated
| import {Static} from "../CoinbaseSmartWallet/Static.sol"; | ||
| import {MockTarget} from "../mocks/MockTarget.sol"; | ||
| import {UserOperation} from "account-abstraction/interfaces/UserOperation.sol"; | ||
| import {console2} from "forge-std/Test.sol"; |
Contributor
There was a problem hiding this comment.
Nit: can we order imports according to the CB solidity style guide? link to imports guide here
amiecorso
reviewed
Sep 11, 2025
Contributor
There was a problem hiding this comment.
I guess it would have been ideal to have put this update in the prior PR which was doing more boilerplate/clean slate stuff, but no need to split this out at this point.
amiecorso
approved these changes
Sep 11, 2025
Contributor
amiecorso
left a comment
amiecorso
left a comment
There was a problem hiding this comment.
lgtm thanks for these!
Dark-Brain07
pushed a commit
to Dark-Brain07/smart-wallet
that referenced
this pull request
Feb 14, 2026
* added e2e tests * changed import ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gas profiling done for native and erc20 transfers. Results in snapshot folder.
https://docs.google.com/document/d/1G-ReRP_SQ4SvbHSjytj_ubdRwXTTMTdlwPAYSyr7LF4/edit?tab=t.0
Tests ran using
FOUNDRY_PROFILE=deployto simulate real-world gas costs