Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
amiecorso
reviewed
Sep 12, 2025
| FreshCryptoLib/=lib/webauthn-sol/lib/FreshCryptoLib/solidity/src/ | ||
| account-abstraction/=lib/account-abstraction/contracts/ | ||
| ds-test/=lib/p256-verifier/lib/forge-std/lib/ds-test/src/ | ||
| ds-test/=lib/v4-core/lib/forge-std/lib/ds-test/src/ |
Contributor
There was a problem hiding this comment.
these ds-test thrashes are weird but i'll trust what's here if it builds
amiecorso
reviewed
Sep 12, 2025
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.23; | |||
| pragma solidity ^0.8.0; | |||
Contributor
There was a problem hiding this comment.
shouldn't change any CoinbaseSmartWallet source code
Contributor
Author
There was a problem hiding this comment.
Uniswap v4 requires solidity > v0.8.26
amiecorso
reviewed
Sep 12, 2025
| PoolModifyLiquidityTest modifyLiquidityRouter; | ||
| PoolKey poolKey; | ||
|
|
||
| uint160 constant SQRT_PRICE_1_1 = 79228162514264337593543950336; // sqrt(1) * 2^96 |
Contributor
There was a problem hiding this comment.
I don't think this is actually used anywhere
amiecorso
reviewed
Sep 12, 2025
test/gas/EndToEnd.t.sol
Outdated
|
|
||
| // Initialize pool with 1:1000000 price ratio (accounting for USDC 6 decimals vs WETH 18 decimals) | ||
| // sqrtPriceX96 = sqrt(10^12) * 2^96 for USDC/WETH decimal adjustment | ||
| uint160 sqrtPriceX96 = 79228162514264337593543950336 * 1e6; |
Contributor
There was a problem hiding this comment.
ah, use named variable here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used uniswapv4 to create liquidity swaps for gas profiling. Tests ran using
FOUNDRY_PROFILE=deployto simulate real-world gas costs