Add warning for safe 7702 upgrades#156
Merged
amiecorso merged 3 commits intocoinbase:mainfrom Jan 14, 2026
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
ilikesymmetry
previously approved these changes
Jan 14, 2026
README.md
Outdated
Comment on lines
+81
to
+87
| ## EIP-7702 delegation safety (important) | ||
| Do **not** directly delegate to a Coinbase Smart Wallet **implementation** contract via EIP-7702. Delegating directly to an implementation can create a security vulnerability. | ||
|
|
||
| Instead: | ||
| - Use the `EIP7702Proxy` pattern: [base/eip-7702-proxy](https://github.com/base/eip-7702-proxy) | ||
| - See Coinbase Developer Platform docs for further guidance and an examples of performing a safe EIP-7702 upgrade: [EIP-7702 FAQs – safe upgrade](https://docs.cdp.coinbase.com/paymaster/need-to-knows/eip-7702-faqs#how-do-i-upgrade-my-wallet-to-7702) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| ## EIP-7702 delegation safety (important) | |
| Do **not** directly delegate to a Coinbase Smart Wallet **implementation** contract via EIP-7702. Delegating directly to an implementation can create a security vulnerability. | |
| Instead: | |
| - Use the `EIP7702Proxy` pattern: [base/eip-7702-proxy](https://github.com/base/eip-7702-proxy) | |
| - See Coinbase Developer Platform docs for further guidance and an examples of performing a safe EIP-7702 upgrade: [EIP-7702 FAQs – safe upgrade](https://docs.cdp.coinbase.com/paymaster/need-to-knows/eip-7702-faqs#how-do-i-upgrade-my-wallet-to-7702) | |
| > [!WARNING] | |
| > ## EIP-7702 delegation safety | |
| > Do **not** directly delegate to a Coinbase Smart Wallet **implementation** contract via EIP-7702. Delegating directly to an implementation can create a security vulnerability. | |
| > | |
| > Instead: | |
| > - Use the `EIP7702Proxy` pattern: [base/eip-7702-proxy](https://github.com/base/eip-7702-proxy) | |
| > - See Coinbase Developer Platform docs for further guidance and an examples of performing a safe EIP-7702 upgrade: [EIP-7702 FAQs – safe upgrade](https://docs.cdp.coinbase.com/paymaster/need-to-knows/eip-7702-faqs#how-do-i-upgrade-my-wallet-to-7702) | |
stevieraykatz
approved these changes
Jan 14, 2026
ilikesymmetry
approved these changes
Jan 14, 2026
danitalexe
added a commit
to danitalexe/smart-wallet
that referenced
this pull request
Jan 14, 2026
This reverts commit 503363d.
Dark-Brain07
pushed a commit
to Dark-Brain07/smart-wallet
that referenced
this pull request
Feb 14, 2026
* add warning not to 7702-delegate directly to CBSW impl * update text for gh style warning * match katzman's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proactive documentation to help devs avoid unsafe direct 7702-delegation to CoinbaseSmartWallet implementation.