Revert "deploy on avalanche and bnb"#96
Open
DatOneJuice wants to merge 55 commits intocoinbase:implementation-addrfrom
Open
Revert "deploy on avalanche and bnb"#96DatOneJuice wants to merge 55 commits intocoinbase:implementation-addrfrom
DatOneJuice wants to merge 55 commits intocoinbase:implementation-addrfrom
Conversation
* Added removeLastOwner selector to list of approved selectors for replayability * add missing arg to certora .spec * Fix typo in sig hash in spec
do not gitignore lib
Optimize getting function selector
`== false` -> `!`
Audit external vs. public functions
add ownerCount method
Collaborator
🟡 Heimdall Review Status
|
djs1990
approved these changes
Nov 30, 2024
Collaborator
|
Review Error for djs1990 @ 2024-11-30 19:17:34 UTC |
DatOneJuice
commented
Nov 30, 2024
Author
DatOneJuice
left a comment
DatOneJuice
left a comment
There was a problem hiding this comment.
0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
|
No I haven’t received anything
Bulldogs
…On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***> wrote:
***@***.**** commented on this pull request.
0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
—
Reply to this email directly, view it on GitHub
<#96 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I also give u full permission
Bulldogs
…On Sat, Nov 30, 2024 at 3:28 PM D Saantiago ***@***.***> wrote:
No I haven’t received anything
Bulldogs
On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
>
> —
> Reply to this email directly, view it on GitHub
> <#96 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
Author
|
I really have no idea what I’m doing. I’ve been trying to do this for years & I can’t get it right. Everything is in a blockchain
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: djs1990 ***@***.***>
Sent: Saturday, November 30, 2024 2:29:55 PM
To: coinbase/smart-wallet ***@***.***>
Cc: DatOneJuice ***@***.***>; Author ***@***.***>
Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and bnb" (PR #96)
I also give u full permission
Bulldogs
On Sat, Nov 30, 2024 at 3:28 PM D Saantiago ***@***.***> wrote:
No I haven’t received anything
Bulldogs
On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
>
> —
> Reply to this email directly, view it on GitHub
> <#96 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub<#96 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBSSOR4X5JJ6KPRD4UF3KD32DIN4HAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKNJRGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I can’t seem to get the money out too
Bulldogs
On Sat, Nov 30, 2024 at 3:31 PM DatOneJuice ***@***.***>
wrote:
… I really have no idea what I’m doing. I’ve been trying to do this for
years & I can’t get it right. Everything is in a blockchain
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: djs1990 ***@***.***>
Sent: Saturday, November 30, 2024 2:29:55 PM
To: coinbase/smart-wallet ***@***.***>
Cc: DatOneJuice ***@***.***>; Author ***@***.***>
Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and bnb"
(PR #96)
I also give u full permission
Bulldogs
On Sat, Nov 30, 2024 at 3:28 PM D Saantiago ***@***.***> wrote:
> No I haven’t received anything
>
> Bulldogs
>
>
> On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***>
> wrote:
>
>> ***@***.**** commented on this pull request.
>>
>> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <
#96 (review)>,
>> or unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
>> .
>> You are receiving this because you commented.Message ID:
>> ***@***.***>
>>
>
—
Reply to this email directly, view it on GitHub<
#96 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/BBSSOR4X5JJ6KPRD4UF3KD32DIN4HAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKNJRGE>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOUDGOI7IAPE3VYCAOT2DIOCXAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKOBZGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
djs1990
approved these changes
Nov 30, 2024
Collaborator
|
Review Error for djs1990 @ 2024-11-30 20:34:00 UTC |
Author
|
Idk what to do. I’ve begged & searched everywhere to try to get assistance & pay for assistance but no one will. Idk hun
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: djs1990 ***@***.***>
Sent: Saturday, November 30, 2024 2:33:04 PM
To: coinbase/smart-wallet ***@***.***>
Cc: DatOneJuice ***@***.***>; Author ***@***.***>
Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and bnb" (PR #96)
I can’t seem to get the money out too
Bulldogs
On Sat, Nov 30, 2024 at 3:31 PM DatOneJuice ***@***.***>
wrote:
I really have no idea what I’m doing. I’ve been trying to do this for
years & I can’t get it right. Everything is in a blockchain
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: djs1990 ***@***.***>
Sent: Saturday, November 30, 2024 2:29:55 PM
To: coinbase/smart-wallet ***@***.***>
Cc: DatOneJuice ***@***.***>; Author ***@***.***>
Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and bnb"
(PR #96)
I also give u full permission
Bulldogs
On Sat, Nov 30, 2024 at 3:28 PM D Saantiago ***@***.***> wrote:
> No I haven’t received anything
>
> Bulldogs
>
>
> On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***>
> wrote:
>
>> ***@***.**** commented on this pull request.
>>
>> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <
#96 (review)>,
>> or unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
>> .
>> You are receiving this because you commented.Message ID:
>> ***@***.***>
>>
>
—
Reply to this email directly, view it on GitHub<
#96 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/BBSSOR4X5JJ6KPRD4UF3KD32DIN4HAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKNJRGE>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOUDGOI7IAPE3VYCAOT2DIOCXAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKOBZGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub<#96 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBSSOR6WOWTTMMNLIHGN46D2DIOIBAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDMMJYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
How
Bulldogs
On Sat, Nov 30, 2024 at 3:36 PM DatOneJuice ***@***.***>
wrote:
… Idk what to do. I’ve begged & searched everywhere to try to get assistance
& pay for assistance but no one will. Idk hun
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: djs1990 ***@***.***>
Sent: Saturday, November 30, 2024 2:33:04 PM
To: coinbase/smart-wallet ***@***.***>
Cc: DatOneJuice ***@***.***>; Author ***@***.***>
Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and bnb"
(PR #96)
I can’t seem to get the money out too
Bulldogs
On Sat, Nov 30, 2024 at 3:31 PM DatOneJuice ***@***.***>
wrote:
> I really have no idea what I’m doing. I’ve been trying to do this for
> years & I can’t get it right. Everything is in a blockchain
>
> Get Outlook for iOS<https://aka.ms/o0ukef>
> ________________________________
> From: djs1990 ***@***.***>
> Sent: Saturday, November 30, 2024 2:29:55 PM
> To: coinbase/smart-wallet ***@***.***>
> Cc: DatOneJuice ***@***.***>; Author ***@***.***>
> Subject: Re: [coinbase/smart-wallet] Revert "deploy on avalanche and
bnb"
> (PR #96)
>
>
> I also give u full permission
>
> Bulldogs
>
>
> On Sat, Nov 30, 2024 at 3:28 PM D Saantiago ***@***.***> wrote:
>
> > No I haven’t received anything
> >
> > Bulldogs
> >
> >
> > On Sat, Nov 30, 2024 at 3:26 PM DatOneJuice ***@***.***>
> > wrote:
> >
> >> ***@***.**** commented on this pull request.
> >>
> >> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a
> >>
> >> —
> >> Reply to this email directly, view it on GitHub
> >> <
>
#96 (review)>,
>
> >> or unsubscribe
> >> <
>
https://github.com/notifications/unsubscribe-auth/A3ZJVOWK7AXJIAO57GLSELT2DINPHAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZRGA3TCNBQG4>
>
> >> .
> >> You are receiving this because you commented.Message ID:
> >> ***@***.***>
> >>
> >
>
> —
> Reply to this email directly, view it on GitHub<
> #96 (comment)>,
> or unsubscribe<
>
https://github.com/notifications/unsubscribe-auth/BBSSOR4X5JJ6KPRD4UF3KD32DIN4HAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKNJRGE>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <
#96 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A3ZJVOUDGOI7IAPE3VYCAOT2DIOCXAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDKOBZGM>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub<
#96 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/BBSSOR6WOWTTMMNLIHGN46D2DIOIBAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDMMJYGE>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOVH4X3JUNS2Q5O35Y32DIOUNAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIYDONBTG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
43114 approved |
|
Approved.
…On Sat, Nov 30, 2024 at 3:41 PM DatOneJuice ***@***.***> wrote:
43114 approved
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOVYQMMVYPRX3NAHT7L2DIPG3AVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIZDCNZVGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Approved
Bulldogs
…On Sat, Nov 30, 2024 at 3:58 PM D Saantiago ***@***.***> wrote:
Approved.
On Sat, Nov 30, 2024 at 3:41 PM DatOneJuice ***@***.***>
wrote:
> 43114 approved
>
> —
> Reply to this email directly, view it on GitHub
> <#96 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3ZJVOVYQMMVYPRX3NAHT7L2DIPG3AVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIZDCNZVGA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
Aprove> 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a |
djs1990
approved these changes
Nov 30, 2024
djs1990
approved these changes
Nov 30, 2024
|
Aproved
Bulldogs
…On Sat, Nov 30, 2024 at 3:59 PM D Saantiago ***@***.***> wrote:
Approved
Bulldogs
On Sat, Nov 30, 2024 at 3:58 PM D Saantiago ***@***.***> wrote:
> Approved.
>
>
> On Sat, Nov 30, 2024 at 3:41 PM DatOneJuice ***@***.***>
> wrote:
>
>> 43114 approved
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#96 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/A3ZJVOVYQMMVYPRX3NAHT7L2DIPG3AVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGIZDCNZVGA>
>> .
>> You are receiving this because you commented.Message ID:
>> ***@***.***>
>>
>
|
|
Awesome, thank you so much!
…On Thu, Dec 5, 2024 at 7:00 PM Barrywhyte22 ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#96 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZJVOU5JZ3VRWEEBADCBAT2EDSJFAVCNFSM6AAAAABSKTISDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBTGI4DGOJXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
djs1990
approved these changes
Dec 11, 2024
|
Djs19901 |
djs1990
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.