Allow specification of additional packages in workspaces - #66
Merged
Conversation
When cargo itself encounters a workspace, it inspects member directories for crates and does not search any other subdirectories of the workspace for packages. The workspace support in colcon behaves the same. It may be desirable to include additional packages in colcon's discovery which are not members of the workspace. This change adds a metadata value at `workspace.metadata.colcon.additional-packages` which behaves similarly to `workspace.members` so that packages under those paths are discovered by colcon. The packages need not be cargo packages themselves but if they are, they will not be treated as cargo workspace members but rather as independent packages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 72.22% 72.46% +0.24%
==========================================
Files 9 9
Lines 342 345 +3
Branches 59 60 +1
==========================================
+ Hits 247 250 +3
Misses 61 61
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cargo itself encounters a workspace, it inspects member directories for crates and does not search any other subdirectories of the workspace. The workspace support in colcon behaves the same.
It may be desirable to include additional packages in colcon's discovery which are not members of the workspace. This change adds a metadata value at
workspace.metadata.colcon.additional-packageswhich behaves similarly toworkspace.membersso that packages under those paths are discovered by colcon. The packages need not be cargo packages themselves but if they are, they will not be treated as cargo workspace members but rather as independent packages.Closes #63