Skip to content

Remove warnings during build and ignore built artifacts. - #53

Merged
cottsay merged 2 commits into
colcon:masterfrom
leander-dsouza:pkg_build
Oct 7, 2025
Merged

Remove warnings during build and ignore built artifacts.#53
cottsay merged 2 commits into
colcon:masterfrom
leander-dsouza:pkg_build

Conversation

@leander-dsouza

Copy link
Copy Markdown
Contributor

Description of contribution in a few bullet points

  • Official Python packaging documentation now recommends using SPDX expressions instead of Trove's classifiers, and resolves the following warning:

    dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
    !!
    
            ********************************************************************************
            Please consider removing the following classifiers in favor of a SPDX license expression:
    
            License :: OSI Approved :: MIT License
    
            See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
            ********************************************************************************
    !!
    
  • Added ignores for the dist/ directory to avoid built artifacts from registering as commits.

Description of how this change was tested

  • No warnings when invoking python3 -m build.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@codecov-commenter

codecov-commenter commented Oct 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (983c232) to head (3688b1b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #53   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          11      11           
  Lines         551     551           
======================================
  Misses        551     551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leander-dsouza
leander-dsouza marked this pull request as ready for review October 7, 2025 05:41

@cottsay cottsay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a leading slash to the .gitignore and set the license expression to use SPDX since the classifier is being removed.

Thanks!

@cottsay
cottsay merged commit c91a0fd into colcon:master Oct 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants