Fix reference site patch in test_deprecations - #57
Merged
Conversation
We should patch the reference site, not the definition site for a more robust patch. Fixes 9f2dc67
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 15.30% 15.30%
=======================================
Files 11 11
Lines 562 562
Branches 94 94
=======================================
Hits 86 86
Misses 474 474
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@leander-dsouza if you could take a look, this is a follow-up to the last PR and will help us clean up the import hacks in #54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should patch the reference site, not the definition site for a more robust patch.
https://docs.python.org/3/library/unittest.mock.html#where-to-patch
Fixes #55