Skip to content

Fix reference site patch in test_deprecations - #57

Merged
cottsay merged 1 commit into
masterfrom
cottsay/deprecation-test-fix
Nov 25, 2025
Merged

Fix reference site patch in test_deprecations#57
cottsay merged 1 commit into
masterfrom
cottsay/deprecation-test-fix

Conversation

@cottsay

@cottsay cottsay commented Nov 24, 2025

Copy link
Copy Markdown
Member

We should patch the reference site, not the definition site for a more robust patch.

https://docs.python.org/3/library/unittest.mock.html#where-to-patch

Fixes #55

We should patch the reference site, not the definition site for a more
robust patch.

Fixes 9f2dc67
@codecov-commenter

codecov-commenter commented Nov 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.30%. Comparing base (9f2dc67) to head (b7613f8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files          11       11           
  Lines         562      562           
  Branches       94       94           
=======================================
  Hits           86       86           
  Misses        474      474           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay

cottsay commented Nov 24, 2025

Copy link
Copy Markdown
Member Author

@leander-dsouza if you could take a look, this is a follow-up to the last PR and will help us clean up the import hacks in #54.

@cottsay
cottsay merged commit ebedd27 into master Nov 25, 2025
23 checks passed
@cottsay
cottsay deleted the cottsay/deprecation-test-fix branch November 25, 2025 20:15
@cottsay cottsay added this to the 0.3.0 milestone Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants