Skip to content

Optionally break version-incompatible dependencies - #45

Merged
cottsay merged 4 commits into
masterfrom
cottsay/skip-incompatible
Mar 24, 2026
Merged

Optionally break version-incompatible dependencies#45
cottsay merged 4 commits into
masterfrom
cottsay/skip-incompatible

Conversation

@cottsay

@cottsay cottsay commented Feb 23, 2026

Copy link
Copy Markdown
Member

This flag is intended to support scenarios where a developer intentionally includes packages in a workspace where the underlying build system will not use dependencies which have incompatible versions.

Because this scenario is somewhat of a deviation from the established expectations of colcon behavior, we'll print a warning to the developer (at least for now).

At this stage in package enumeration, we may encounter multiple packages with a given name. This change also re-structures the enumeration so that all packages with a given name can be checked, where previously only a single instance of the package was checked.

This flag is intended to support scenarios where a developer
intentionally includes packages in a workspace where the underlying
build system will not use dependencies which have incompatible versions.

Because this scenario is somewhat of a deviation from the established
expectations of colcon behavior, we'll print a warning to the developer
(at least for now).

At this stage in package enumeration, we may encounter multiple packages
with a given name. This change also re-structures the enumeration so
that all packages with a given name can be checked, where previously
only a single instance of the package was checked.
@cottsay cottsay self-assigned this Feb 23, 2026
@codecov-commenter

codecov-commenter commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.92%. Comparing base (1c1c0ad) to head (76beea9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   13.37%   15.92%   +2.55%     
==========================================
  Files           5        5              
  Lines         329      339      +10     
  Branches       93       96       +3     
==========================================
+ Hits           44       54      +10     
  Misses        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay
cottsay requested a review from Blast545 February 25, 2026 03:43

@Blast545 Blast545 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Comment thread colcon_package_information/package_augmentation/check_dependency_constraint.py Outdated
Co-authored-by: Jorge J. Perez <j.j.perez13@hotmail.com>
@cottsay
cottsay marked this pull request as ready for review March 24, 2026 16:52
@cottsay
cottsay merged commit a24ccbc into master Mar 24, 2026
22 checks passed
@cottsay
cottsay deleted the cottsay/skip-incompatible branch March 24, 2026 18:50
@cottsay cottsay added this to the 0.4.1 milestone Mar 27, 2026
@cottsay cottsay added the enhancement New feature or request label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants