-
Notifications
You must be signed in to change notification settings - Fork 15
Update README with newest features / architecture #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luca-della-vedova
wants to merge
1
commit into
main
Choose a base branch
from
luca/update_readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this section?
Make sure that you have built and loaded (`source install/setup.bash`) the extension.As a newcomer to the tool, from the usage described in: https://github.com/ros2-rust/ros2_rust?tab=readme-ov-file#sounds-great-how-can-i-try-this-out
It seems like we source the workspace of Rust crates after we build the ROS workspace. Is my understanding incorrect?
I would expect that we don't have to source anything from colcon-ros-cargo since it's a colcon extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's perhaps a bit redundant and more of a general direction about how to install
colconextensions, since for now there are no debian packages this can only bepip installed (with the scary--break-system-packagesflag) or put in acolconworkspace andcolcon build.I gave it a quick try and indeed if I have a workspace with this colcon extension and a package that would be built by it (something that is identified as a
ros.ament_cargopackage namedexample) the following seem to be true:colcon build --packages-up-to exampledoesn't build this colcon extension, which makes sense since it's not an explicit dependency I guess.colcon build --packages-select colcon-ros-cargo, followed bycolcon build --package-select exampledoes not correctly identify the package, and colcon still reports that it doesn't know how to handle aros.ament_cargopackage.colcon build --packages-select colcon-ros-cargo, followed by asource install/setup.bash, followed by acolcon build --packages-select examplecorrectly works, suggesting that indeed colcon extensions need to be built and sourced before they can be used.