Skip to content

Update requirements.txt to reflect changes to setup.cfg - #111

Merged
cottsay merged 2 commits into
mainfrom
cottsay/new-reqs
May 16, 2026
Merged

Update requirements.txt to reflect changes to setup.cfg#111
cottsay merged 2 commits into
mainfrom
cottsay/new-reqs

Conversation

@cottsay

@cottsay cottsay commented May 2, 2026

Copy link
Copy Markdown
Member

These changes to the setup.cfg in colcon-core didn't get copied to this requirements file for bootstrapping colcon.

These changes to the setup.cfg in colcon-core didn't get copied to this
requirements file for bootstrapping colcon.
@cottsay cottsay self-assigned this May 2, 2026

@Zyrin Zyrin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the boorstrap process works now, but it does prints deprecation warnings:

setuptools/dist.py:759: SetuptoolsDeprecationWarning: 

License classifiers are deprecated.
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: Apache Software License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

!!
  self._finalize_license_expression()
---

@Zyrin

Zyrin commented May 3, 2026

Copy link
Copy Markdown
Contributor

The boostrap instructions also contain the line pip install -U pip setuptools. Maybe that should also be removed.

@cottsay

cottsay commented May 15, 2026

Copy link
Copy Markdown
Member Author

The boostrap instructions also contain the line pip install -U pip setuptools. Maybe that should also be removed.

Nice catch, fixed in 0b11d70.

@cottsay
cottsay merged commit f19adf8 into main May 16, 2026
2 checks passed
@cottsay
cottsay deleted the cottsay/new-reqs branch May 16, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants