fix(providers): update package imports from @mariozechner to @earendil-works#1732
fix(providers): update package imports from @mariozechner to @earendil-works#1732jkbjhs-potluck wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
📝 WalkthroughWalkthroughThis PR migrates the Pi community provider from the ChangesPi SDK Migration and Tool Wiring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97655b8d68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tools: [...PI_DEFAULT_TOOL_NAMES], | ||
| ...(customBashTool ? { customTools: [customBashTool] } : {}), |
There was a problem hiding this comment.
Avoid narrowing tool allowlist in env-only path
When requestOptions.env is set and no allowed_tools/denied_tools are provided, this branch now sends tools: ["read","bash","edit","write"] to Pi. In the new @earendil-works/pi-coding-agent API, tools is a global allowlist (including extension/custom tools), so this unintentionally disables extension-registered tools by default whenever env injection is used. That regresses extension workflows (which are enabled by default in PiProvider) even though the user did not request tool restriction.
Useful? React with 👍 / 👎.
PR Review Summary — Multi-AgentSix specialized reviewers (code, docs-impact, tests, types, comments, silent-failure) ran against this PR. Migration mechanics are sound; findings are concentrated around (a) one missed doc file, (b) test-assertion gaps for the new Critical Issues (0)None. The SDK migration is mechanically correct, the lazy-load guarantee is preserved, the Important Issues (5)
Suggestions (4)
Strengths
Documentation
VerdictREADY TO MERGE WITH MINOR FIXES — no production bugs found. I1 ( Recommended Actions
|
Review SummaryVerdict: minor-fixes-needed This PR migrates the Pi community provider from Blocking issuesNone. Suggested fixes
Minor / nice-to-have
Compliments
Reviewed via maintainer-review-pr workflow (Pi/Minimax). Aspects run: code-review, error-handling, test-coverage, comment-quality, docs-impact. |
Summary
Describe this PR in 2-5 bullets:
@mariozechner/*Pi packages, whose embedded model catalog does not includeopenai-codex/gpt-5.5.provider: piworkflows usingmodel: openai-codex/gpt-5.5fail before execution withPi model not found, even though current upstream Pi supports the model.@earendil-works/pi-ai/@earendil-works/pi-coding-agent^0.75.3, refreshedbun.lock, updated Pi imports/docs/tests, and added a regression test that resolvesopenai-codex/gpt-5.5through Pi'sModelRegistry.UX Journey
Before
After
Architecture Diagram
Before
After
Connection inventory (list every module-to-module edge, mark changes):
packages/providers/package.json@earendil-works/pi-ai@mariozechner/pi-aidependency.packages/providers/package.json@earendil-works/pi-coding-agent@mariozechner/pi-coding-agentdependency.packages/providers/package.json@mariozechner/pi-aipackages/providers/package.json@mariozechner/pi-coding-agentPiProvider.provider.ts@earendil-works/pi-coding-agentevent-bridge.ts@earendil-works/pi-coding-agent/@earendil-works/pi-aioptions-translator.ts@earendil-works/pi-coding-agentcreateBashToolDefinitionpluscustomToolsfor env-aware bash under the new SDK API.resource-loader.tsDefaultResourceLoaderagentDir: getAgentDir()for the new SDK API.ui-context-stub.tsExtensionUIContextmodel-catalog.test.tsModelRegistryopenai-codex/gpt-5.5resolves.@earendil-works/*.Label Snapshot
risk: mediumsize: Mdependencies,tests,docsproviders:piChange Metadata
bugmultiLinked Issue
Validation Evidence (required)
Commands and result summary:
bun install bun --filter @archon/providers type-check bun --filter @archon/providers test bun run validate TARGET=bun-darwin-arm64 OUTFILE=dist/binaries/archon-darwin-arm64 bash scripts/build-binaries.sh install -m 755 dist/binaries/archon-darwin-arm64 /opt/homebrew/bin/archon archon versionbun installcompleted and refreshedbun.lockto@earendil-works/pi-ai@0.75.3and@earendil-works/pi-coding-agent@0.75.3.bun --filter @archon/providers type-checkexited with code 0.bun --filter @archon/providers testexited with code 0.bun run validateexited with code 0 after bundled checks, type-check, lint, format check, and package-isolated tests.TARGET=bun-darwin-arm64 OUTFILE=dist/binaries/archon-darwin-arm64 bash scripts/build-binaries.shproduceddist/binaries/archon-darwin-arm64(~68 MB)./opt/homebrew/bin/archonand verifiedarchon versionreportsArchon CLI v0.3.12,Build: binary,Git commit: 5283ea93.Security Impact (required)
Yes/No): NoYes/No): NoYes/No): NoYes/No): NoYes, describe risk and mitigation: N/A. This updates the bundled Pi SDK package namespace/version and adapts to its API; it does not add new Archon runtime permissions, network calls, secret stores, or filesystem scopes.Compatibility / Migration
Yes/No): YesYes/No): NoYes/No): NoHuman Verification (required)
What was personally validated beyond CI:
@earendil-works/pi-coding-agentModelRegistryresolvesopenai-codex/gpt-5.5.packages/providers/src/community/pi/model-catalog.test.tscovering that resolution./opt/homebrew/bin/archonand verifiedarchon versionruns from PATH.tools/customToolsAPI.openai-codex/gpt-5.5was not executed; validation is limited to catalog/model resolution and provider integration tests.Side Effects / Blast Radius (required)
packages/providers/src/community/pi/*).customToolshook rather than passing constructed tool objects directly.bun run validatepasses.ModelRegistryregression catches stale catalogs that dropopenai-codex/gpt-5.5.Rollback Plan (required)
@mariozechner/*Pi dependencies and previous provider integration code, then rebuild/reinstall the Archon binary.provider: pi+model: openai-codex/gpt-5.5again reportsPi model not found.Risks and Mitigations
List real risks in this PR (or write
None).@mariozechner/*packages to current@earendil-works/*packages changes SDK APIs used by the provider.DefaultResourceLoader,ExtensionUIContext, tool restriction/env passthrough handling) and ran provider tests plus fullbun run validate.openai-codex/gpt-5.5API call.ModelRegistry.find; the new regression directly covers that failure point.Summary by CodeRabbit
Chores
Tests
Documentation
New Features