fix(v4): improve error messages for Infinity, NaN, and Invalid Date #5230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, parsing Infinity with z.number() showed the confusing error: "Invalid input: expected number, received number" This fix updates error message generation to properly display: - "received Infinity" for infinite values - "received NaN" for NaN values - "received Invalid Date" for invalid dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the confusing error messages when validating special numeric values (Infinity, NaN) and invalid dates with Zod schemas. Closes #5186
Problem
When parsing Infinity with z.number(), the error message was:
Invalid input: expected number, received numberThis was confusing because it appeared to say the same type was both expected and received.
Solution
issue.receivedfield before falling back to parsedType()