Skip to content

Conversation

gebsh
Copy link

@gebsh gebsh commented Oct 16, 2025

Fixes #5350.

@colinhacks
Copy link
Owner

Unfortunately this would break any code that's expecting these values to be some kind of numeric value. I think the better solution would be to convert the Date values to a Unix timestamp here. I'm pretty sure the reason I omitted Date in the first place was so it would be easier to do error customization for "too_small" and "too_big", and I think I kinda forgot to do the Date -> number conversion 😅

@gebsh
Copy link
Author

gebsh commented Oct 22, 2025

Oh, okay. That's fine too, I think, since a timestamp can be turned into a Date object by an error map anyway. I'll update this PR later to do the conversion instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Date variant in types of too small/big errors

2 participants