Compiler compatibility Fix #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this should resolve the issue with the complier!
Author
|
@colinmollenhour Could you check and let me know. |
Owner
|
Looks like it should work, but I don't use the compiler, it doesn't seem to have any real benefit and just complicates things.. No objection to merging it if you remove the repetition by using a variable. |
himanshutecstub
left a comment
himanshutecstub
left a comment
There was a problem hiding this comment.
It's not working when enable compilation in magento 1.9.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should resolve the issue with the complier!