Added ember package #20
Conversation
|
@gitaalekhyapaul created a sample route |
|
Creating a To use Ember to perform a swap action |
There was a problem hiding this comment.
- EmberClient needs to always be instantiated with a URL and optional API key.
- There is no
getClientmethod. It's instantiated directly.
const client = new EmberClient({
endpoint: process.env.EMBER_ENDPOINT_URL, // grpc.api.emberai.xyz:50051
apiKey: process.env.EMBER_API_KEY,
})
- The
/agent/swapendpoint is incorrectly instantiating the EmberClient. See above example. - There are only two options active for swap
typeright now.MARKET_BUY- buys the base token with the quote tokenMARKET_SELL- sells the base token for the quote token
There was a problem hiding this comment.
@0xTomDaniel changed the order Type, this method is a wrapper included in the ember.service, to follow convention - beihnd the scenes is the same
There was a problem hiding this comment.
I see. Sorry I completely overlooked that!
|
I've published v0.2.0 of the SDK. Please update.
|
There was a problem hiding this comment.
Am I correct in understanding that this is just a proof-of-concept that will be refactored?
- Sorry if I'm pointing out the obvious, but I just want to note that the execute swap route definitely shouldn't be hard coded to always swap the same thing
- Also, the ideal use of Ember is that methods should be packaged as Tools (Actions) for the agent to call
- The agent signs the transaction returned by Ember with its own agent wallet
There was a problem hiding this comment.
@0xTomDaniel yes, this would't be useful released as this
waiting for some agent documentation, or someone to refactor into the workflow. but they wanted to check how things are working
I was traveling but we'll be around for a few days if we have instructions to execute
There was a problem hiding this comment.
@0xTomDaniel if you understand the flow better, and have that info, we can develop that together. we could find more in the chat and improve the documentation in this repo with some examples and diagrams


Description
Added ember dependencies to server/package.json
Created route for /ember
Created ember service, and initializing in route
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Related Issues