-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for quick-xml 0.38 and update CI to Rust 1.85 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot Please update rust toolchain in the github workflows to the version in Debian stable and test compilation with that version specifically |
Could you clarify which Rust version is in Debian stable? I tested with Rust 1.63.0 (the original Bookworm release), but it fails due to dependency requirements:
The CI currently uses Rust 1.70, which works successfully. Should I:
Please let me know the target version and I'll update accordingly. |
|
@copilot Debian stable is Debian Trixie, which has rust 1.85; So please update to match that |
Updated the CI workflow to use Rust 1.85 to match Debian Trixie stable. All jobs (check, fmt, test, clippy) now use toolchain "1.85". Tested successfully with Rust 1.85.1 - all tests pass. (commit: see latest commit) |
2e6caae to
9051b86
Compare
|
@copilot the rustc version updates is cause cargo fmt and clippy errors; please resolve those. Overall make sure the github actions test can succeed |
Fixed all clippy and fmt errors for Rust 1.85. Changes include:
All CI checks now pass: cargo check ✓, cargo fmt ✓, cargo test ✓, cargo clippy ✓ (commit: see latest) |
New quick-xml doesn't by default trim text elements anymore. Unfortunately quick-xml cannot really be configured for this either, see tafia/quick-xml#900 for more details. For now add a small deserializing helper to trim to work around this
Rust 1.85 is the current version in Debian Trixie, so update to that. Co-authored-by: sjoerdsimons <[email protected]>
e91418d to
b0e1e40
Compare
Summary
Successfully updated bmap-parser to support quick-xml 0.38 and updated CI to use Rust 1.85 to match Debian Trixie stable. Fixed all clippy and fmt errors introduced by Rust 1.85.
Changes:
xml.rsto trim whitespacexml.rsas_slice()calls with slice syntax&[..]block_map()return type.truncate(true)to file open operations for clippy complianceTesting:
Original prompt
Fixes #91
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.