Some overdue cleanup - #65
Merged
Merged
Conversation
Configuration gets a timeout and added to request setup. The timeout matches Net HTTP defaults so should be backwards compat. Configuration uses accessor to set (no poking at internals). Default headers made reasonable, no placeholder values. Request sets basic_auth via options like everything (httparty is weird). Adds a User-Agent for the client. Fix passed in options (a reference) being mutated by Request.
Member
Author
|
@kspurgin I didn't touch the version, happy to let you handle it as a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration gets a timeout and added to request setup.
The timeout matches Net HTTP defaults so should be backwards compat.
Configuration uses accessor to set (no poking at internals).
Default headers made reasonable, no placeholder values.
Request sets basic_auth via options like everything (httparty is weird).
Adds a User-Agent for the client.
Fix passed in options (a reference) being mutated by Request.