DRYD-1923: Accessibility > Resolve orphaned form labels (Criteria 3.3.2) - #25
Merged
Conversation
…el to clone pre-built Labels including the new props; extended labelable to pass htmlFor and id to normalizeLabel;
…nd; updated labelable to pass label as an input when useLegend flag is true instead of rendering it;
…hat it renders a legend instead of an orphaned label; added id prop to children elements; updated repeatable to pass id as an input;
… propagate id through CustomCompoundInput.decorateInputs
spirosdi
requested review from
Copilot and
mikejritter
and removed request for
Copilot
May 11, 2026 08:38
mikejritter
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
htmlForandidprops toLabel.<label>includes both of them. In case of prebuiltLabel,normalizeLabelclones and injects the props when not existing.<fieldset>components (CustomCompoundInput,RepeatingInput,TabularCompoundInput,InputTable),labelaleforwards label as a prop instead of rendering and the component renders a<legend>element.Why are we doing this? (with JIRA link)
In the edit-record view there are a lot of orphaned labels (labels not associated to an input). The solution is to add a htmlFor label attribute pointing to a newly added input id. This task is only about fixing the orphaned labels. The missing labels, missing legend issues will be resolved in other tasks.
How should this be tested? Do these changes have associated tests?
Please follow test instructions here: collectionspace/cspace-ui.js#351
Dependencies for merging? Releasing to production?
N/A
Has the application documentation been updated for these changes?
Changelog has been updated
Did someone actually run this code to verify it works?
@spirosdi ran it locally