DRYD-1925 Accessibility > Contrast/Design of Buttons (Criteria 1.4.3) - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It resolves the very low contrast issue of buttons. It also changes the bg color of the delete button. The updates include:
buttonBg, buttonBgActive, buttonBgDisabled, deleteButtonBg, deleteButtonBgActivecolors.Why are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-1925
How should this be tested? Do these changes have associated tests?
Please check the instructions in collectionspace/cspace-ui.js#352
Dependencies for merging? Releasing to production?
no dependencies
Has the application documentation been updated for these changes?
changelog has been updated
Did someone actually run this code to verify it works?
@spirosdi ran it locally