Skip to content

Improved utils convert function to convert files other than odt#73

Merged
sgeulette merged 2 commits into3.xfrom
SE-280/convert_files
Jan 6, 2026
Merged

Improved utils convert function to convert files other than odt#73
sgeulette merged 2 commits into3.xfrom
SE-280/convert_files

Conversation

@chris-adam
Copy link
Contributor

@chris-adam chris-adam commented Jan 5, 2026

J'ai finalement appris de odfsplit et j'ai utilisé la même approche pour ne plus passer par le renderer et pouvoir convert des fichiers autres que odt
Je n'ai pas approfondi les tests en conséquence, ça reste faisable plus tard

@chris-adam chris-adam requested a review from sgeulette January 5, 2026 14:12
@chris-adam chris-adam force-pushed the SE-280/convert_files branch from 5be85ce to 33f3a8c Compare January 5, 2026 14:29
@chris-adam chris-adam force-pushed the SE-280/convert_files branch from 33f3a8c to 1599ff7 Compare January 5, 2026 14:39
@coveralls
Copy link

coveralls commented Jan 5, 2026

Coverage Status

coverage: 90.382% (-0.1%) from 90.506%
when pulling 6d07007 on SE-280/convert_files
into afaddd7 on 3.x.

temp_file = create_temporary_file(afile, '.odt')
converted_filename = None
from appy.pod import converter
converter_path = converter.__file__.endswith('.pyc') and converter.__file__[:-1] or converter.__file__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il serait préférable d'en faire un script buildout comme pour odfsplit...

@sgeulette sgeulette merged commit 22f5d83 into 3.x Jan 6, 2026
8 of 10 checks passed
@sgeulette sgeulette deleted the SE-280/convert_files branch January 6, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants