Skip to content

Improved convert_odt function to work with not fully rendered document#75

Merged
sgeulette merged 7 commits into3.xfrom
convert_odt
Jan 21, 2026
Merged

Improved convert_odt function to work with not fully rendered document#75
sgeulette merged 7 commits into3.xfrom
convert_odt

Conversation

@sgeulette
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jan 21, 2026

Coverage Status

coverage: 90.33% (-0.06%) from 90.385%
when pulling 1018878 on convert_odt
into b96d8fe on 3.x.

@chris-adam chris-adam self-requested a review January 21, 2026 12:18
Copy link
Contributor

@chris-adam chris-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que convert_odt ne fonctionne pas si on demande le renderer sans gen_context.

Ce n'est pas l'usage prévu mais j'ai tenté la vue "document-conversion" en utilisant convert_file avec le renderer à True

2026-01-21 14:30:25 WARNING collective.documentgenerator Could not remove temporary file at /tmp/tmpyPsmp3.pdf
2026-01-21 14:30:25 ERROR Zope.SiteErrorLog 1769002225.040.317628277602 http://localhost:8081/SE-314/outgoing-mail/202603/dqsd/012999900000019/@@document-conversion
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module collective.documentgenerator.browser.converter, line 23, in __call__
  Module collective.documentgenerator.utils, line 293, in convert_file
  Module collective.documentgenerator.utils, line 260, in convert_odt
  Module appy.pod.renderer, line 862, in run
  Module appy.shared.xml_parser, line 286, in parse
  Module xml.sax.expatreader, line 111, in parse
  Module xml.sax.xmlreader, line 123, in parse
  Module xml.sax.expatreader, line 220, in feed
  Module xml.sax.expatreader, line 339, in end_element
  Module appy.pod.pod_parser, line 371, in endElement
  Module appy.pod.actions, line 162, in execute
  Module appy.pod.actions, line 145, in evaluateExpression
  Module appy.pod.actions, line 96, in manageError
EvaluationError: Error while evaluating expression "view.do_mailing()". NameError: name 'view' is not defined

Edit: Il semblerait que ça soit le cas seulement si j'utilise la fonction sur un document avant publipostage

@sgeulette
Copy link
Member Author

J'ai l'impression que convert_odt ne fonctionne pas si on demande le renderer sans gen_context.

Ce n'est pas l'usage prévu mais j'ai tenté la vue "document-conversion" en utilisant convert_file avec le renderer à True

2026-01-21 14:30:25 WARNING collective.documentgenerator Could not remove temporary file at /tmp/tmpyPsmp3.pdf
2026-01-21 14:30:25 ERROR Zope.SiteErrorLog 1769002225.040.317628277602 http://localhost:8081/SE-314/outgoing-mail/202603/dqsd/012999900000019/@@document-conversion
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module collective.documentgenerator.browser.converter, line 23, in __call__
  Module collective.documentgenerator.utils, line 293, in convert_file
  Module collective.documentgenerator.utils, line 260, in convert_odt
  Module appy.pod.renderer, line 862, in run
  Module appy.shared.xml_parser, line 286, in parse
  Module xml.sax.expatreader, line 111, in parse
  Module xml.sax.xmlreader, line 123, in parse
  Module xml.sax.expatreader, line 220, in feed
  Module xml.sax.expatreader, line 339, in end_element
  Module appy.pod.pod_parser, line 371, in endElement
  Module appy.pod.actions, line 162, in execute
  Module appy.pod.actions, line 145, in evaluateExpression
  Module appy.pod.actions, line 96, in manageError
EvaluationError: Error while evaluating expression "view.do_mailing()". NameError: name 'view' is not defined

Edit: Il semblerait que ça soit le cas seulement si j'utilise la fonction sur un document avant publipostage

C'est parce que maintenant ce n'est plus juste une conversion mais aussi une interprétation. ET essayer de convertir un document qui n'est pas encore totalement rendu va planter si le contexte de génération ne contient pas les éléments dynamiques nécessaires... L'action de conversion est dispo dans le UI ?

@sgeulette sgeulette merged commit b4d5b9d into 3.x Jan 21, 2026
8 of 10 checks passed
@sgeulette sgeulette deleted the convert_odt branch January 21, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants