prevent existing relations from being lost #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context: by storing the existing relations before purging the catalog, and then restoring them from the annotations, we keep all relations in the catalog
|
Yes, this looks good. We discussed that at Ploneconf and found that partial imports that also used import_relations lose data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: When importing content into an existing site, the relations were gone from the catalog.
By storing the existing relations before purging the catalog, and then restoring them from the annotations, we have both the old and newly imported relations post-migration
This is just an idea that seemed to fix it. relates to Issue #22