Skip to content

prevent existing relations from being lost - #268

Merged
pbauer merged 2 commits into
mainfrom
dropped_relations
Nov 6, 2025
Merged

prevent existing relations from being lost#268
pbauer merged 2 commits into
mainfrom
dropped_relations

Conversation

@ThibautBorn

@ThibautBorn ThibautBorn commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

context: When importing content into an existing site, the relations were gone from the catalog.
By storing the existing relations before purging the catalog, and then restoring them from the annotations, we have both the old and newly imported relations post-migration

This is just an idea that seemed to fix it. relates to Issue #22

context: by storing the existing relations before purging the catalog, and then
restoring them from the annotations, we keep all relations in the
catalog
@ThibautBorn
ThibautBorn requested review from gotcha and pbauer October 24, 2025 08:02

@gotcha gotcha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I would feel better if @pbauer could confirm.

@pbauer

pbauer commented Nov 3, 2025

Copy link
Copy Markdown
Member

Yes, this looks good. We discussed that at Ploneconf and found that partial imports that also used import_relations lose data.

@pbauer pbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changenote

@pbauer
pbauer merged commit 0735953 into main Nov 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants