Create parent of the correct type if the parent is missing - #275
Merged
Conversation
gforcada
approved these changes
Dec 19, 2025
gforcada
left a comment
gforcada
left a comment
Member
There was a problem hiding this comment.
Great job! I was planning to work on that, but you beat and very much did all I was thinking I would do if I had enough time 🤩
I mention a few nitpicks, but it's ready to be merged IMHO.
Nice!! 🌟
| title=item["parent"]["title"], | ||
| ) | ||
| except InvalidParameterError: | ||
| logger.info("Cannot add %s notin %r. Fallback to %s", parent_type, container, container_type, exc_info=True) |
Member
There was a problem hiding this comment.
Suggested change
| logger.info("Cannot add %s notin %r. Fallback to %s", parent_type, container, container_type, exc_info=True) | |
| logger.info("Cannot add %s in %r. Fallback to %s", parent_type, container, container_type, exc_info=True) |
| @@ -463,7 +521,7 @@ def test_import_content_from_other_plone_site(self): | |||
| self.assertIn("folder1", portal.contentIds()) | |||
| new_folder = portal["folder1"] | |||
| # The auto generated folder will have its id as title | |||
Member
There was a problem hiding this comment.
There are a few comments that should be amended like this one
Co-authored-by: Maurits van Rees <maurits@vanrees.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #139