Pre-check images so failures in PIL can be tied to a specific item - #279
Closed
valipod wants to merge 1 commit into
Closed
Pre-check images so failures in PIL can be tied to a specific item#279valipod wants to merge 1 commit into
valipod wants to merge 1 commit into
Conversation
Member
|
It would be nice to improve the warning in plone.namedfile to include the exception from Pillow. Would you consider submitting a PR there? https://github.com/plone/plone.namedfile/blob/main/src/plone/namedfile/utils/__init__.py#L243 |
Member
|
Oh, there's already a PR in progress which does that: plone/plone.namedfile#210 |
Contributor
Author
|
My bad, this gets scrapped then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give additional information about the images that fail in PIL, to assist in fixing their problem, otherwise the log info is unhelpful:
WARNING [plone.namedfile.utils:216][waitress-2] PIL can not recognize the image. Image is probably broken or of a non-supported format.