Improved documentation by adding code comments and ensuring consistency#1342
Improved documentation by adding code comments and ensuring consistency#1342Rohit1240 wants to merge 7 commits into
Conversation
…cy in code blocks This PR improves documentation by: - Ensuring consistency in code block formatting - Adding helpful comments to code examples for better understanding
|
Hi, I worked on improving documentation by fixing references to Python objects using fully qualified names. |
|
Hi, thanks for your contribution and time. We require to log the changes in the changelog file. Also, have a look at the failing tests. They need to run. If you have questiins, please ask us! |
stevepiercy
left a comment
There was a problem hiding this comment.
Thanks for your contribution! You caught a few things that were missed, some for over two decades. Would you please take a look at my suggestions?
| >>> cal = Calendar() # create a calendar object | ||
| >>> cal.add("dtstart", datetime(2005,4,4,8,0,0)) # set start date |
There was a problem hiding this comment.
Inline comments should have a minimum of two spaces after the line of code.
| >>> cal = Calendar() # create a calendar object | |
| >>> cal.add("dtstart", datetime(2005,4,4,8,0,0)) # set start date | |
| >>> cal = Calendar() # create a calendar object | |
| >>> cal.add("dtstart", datetime(2005,4,4,8,0,0)) # set start date |
There was a problem hiding this comment.
This suggestion was omitted.
|
Regarding the failing test, this is due to fixing the Sphinx directive, changing it from |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
Hi, we created a new release, please move your edits in CHANGES.rst to the new section. |
stevepiercy
left a comment
There was a problem hiding this comment.
The failing tests are due to fixing the Sphinx directive, changing it from code to code-block, so that the test actually runs for the first time. The output in the documentation should be updated to match the actual Python console output. See https://icalendar.readthedocs.io/en/stable/contribute/documentation/build-check.html#test-code-snippets-and-docstrings.
Also please update your branch against main, then move the change log entry under the unreleased section.
| >>> cal = Calendar() # create a calendar object | ||
| >>> cal.add("dtstart", datetime(2005,4,4,8,0,0)) # set start date |
There was a problem hiding this comment.
This suggestion was omitted.
stevepiercy
left a comment
There was a problem hiding this comment.
@Rohit1240 there are several instances that need to be fixed. Would you please take care? Thank you!
| After loading the example file, edit and save it. | ||
|
|
||
| .. code:: pycon | ||
| .. .. code-block:: pycon |
There was a problem hiding this comment.
This comments out the code-block directive, so the ensuing code block is not rendered correctly. Please change this and all other instances as shown.
| .. .. code-block:: pycon | |
| .. code-block:: pycon |
There was a problem hiding this comment.
Alternatively, rebase your branch on main after #1412 is merged. Thank you!
|
@Rohit1240 also, would you please edit your description from |
…cy in code blocks
This PR improves documentation by:
Closes issue
Replace
ISSUE_NUMBERwith the issue number that your pull request fixes. Then GitHub will link and automatically close the related issue.Description
Write a description of the fixes or improvements.
Checklist
CHANGES.rst.Additional information
Upload screenshots, videos, links to documentation, or any other relevant information.
📚 Documentation preview 📚: https://icalendar--1342.org.readthedocs.build/