Fix line folding across escape sequences#1502
Open
kingrubic wants to merge 1 commit into
Open
Conversation
Contributor
|
Profile summary: Full profile |
Documentation build overview
13 files changed ·
|
angatha
requested changes
Jun 24, 2026
| char_byte_len = len(char.encode(DEFAULT_ENCODING)) | ||
| if current_chars and byte_count + char_byte_len >= limit: | ||
| # Avoid splitting escaped values such as TEXT backslash escapes | ||
| # or RFC 6868 parameter escapes across a folded line boundary. |
Collaborator
There was a problem hiding this comment.
I commented #1501 and asked for a newer RFC version for content line folding. If no one could provide a version explicitly forbidding splitting thouse sequence, can you please include the reason (compatibility) why we aren't following the SHOULD from RFC 5545 or at least link the issue so everyone seeing that code knows that this is intentional.
Besides that, the code looks great.
I would wait for an answer on the issue before accepting that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\n,\,, etc.) and RFC 6868 parameter escapes (^n,^^,^\')Verification
uv run pytest src/icalendar/tests/test_parsing.py -k '1501'uv run pytest src/icalendar/tests/test_parsing.pyuv run pytest(16090 passed, 28 skipped)uv run ruff check src/icalendar/parser/string.py src/icalendar/tests/test_parsing.pyuv run ruff format --check src/icalendar/parser/string.py src/icalendar/tests/test_parsing.py