Skip to content

Add coverage tests for issue 698 - #1629

Open
karurukaruru wants to merge 3 commits into
collective:mainfrom
karurukaruru:agent/issue-698-more-coverage
Open

Add coverage tests for issue 698#1629
karurukaruru wants to merge 3 commits into
collective:mainfrom
karurukaruru:agent/issue-698-more-coverage

Conversation

@karurukaruru

@karurukaruru karurukaruru commented Aug 3, 2026

Copy link
Copy Markdown

Linked issue

Description

Adds focused tests for five uncovered paths involving unknown-property representation, category hashing and representation, invalid calendar dates, and invalid jCal weekday values. No production code is changed.

I used OpenAI Codex (GPT-5.6) to help identify uncovered paths, understand the relevant code, review the tests, and verify formatting, tests, and coverage.

Checklist

  • I added a change log entry, following the instructions in Change log entry format.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

AI disclosure: I used OpenAI Codex (GPT-5.6) to identify uncovered code paths, explain the relevant project code, review the user-authored tests, and verify formatting, tests, and coverage.
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments.

@github-actions github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Profile summary:

GitHub user: karurukaruru
🟡 Some concerns found with user's profile.
🟢 No concerns found with recent PR activity.
🟢 No concerns found with recent issue activity.

For a more detailed report, run `gh-profiler karurukaruru`.
Full profile
GitHub user: karurukaruru
🟡 Some concerns found with user's profile.
   🟢 Account age: 4 days
   🟡 Profile information:
        name: カルル
        twitter: https://x.com/djkaruru
      Empty fields: company, blog, location, email, bio

🟢 No concerns found with recent PR activity.
   1 PR opened in the last 21 days.
      0 opened against repos the user owns.
      0 opened against repos in publicly associated orgs.
      1 opened against external repos.

   🟢 0 of 1 external PRs merged in the last 21 days.
   🟢 0 of 1 external PRs closed without merging in the last 21 days.

🟢 No concerns found with recent issue activity.
   🟢 No new issues opened in the last 21 days.

@karurukaruru karurukaruru reopened this Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments.

@read-the-docs-community

read-the-docs-community Bot commented Aug 3, 2026

Copy link
Copy Markdown

@karurukaruru

Copy link
Copy Markdown
Author

Hello, thank you for reviewing my first PR.
I created this GitHub account four days ago. The bot may have marked my PR because this account is new.
I am not a native English speaker. I started learning Python again about one month ago. I used OpenAI Codex (GPT-5.6) to help me understand the project, review the tests, write English, and read the test results.
I added tests for five places that did not have tests before. I did not change the project code. I only added tests. I checked the changes and I can explain them.
Could you please review my PR? Thank you very much.

@karurukaruru
karurukaruru marked this pull request as ready for review August 3, 2026 14:33
stevepiercy
stevepiercy previously approved these changes Aug 4, 2026

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! The work LGTM.

Let's get a technical review. There may be a preferred way to organize the tests in existing test files or parametrize them.

@SashankBhamidi SashankBhamidi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and welcome. I ran all five tests and they pass.

One thing to address inline.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests should be split into their natural homes rather than collected in a new file.

  • test_vunknown_repr belongs in src/icalendar/tests/test_issue_1445.py, that's where all vUnknown tests live.
  • test_vcategory_hash and test_vcategory_repr belong in src/icalendar/tests/prop/test_unit.py alongside the existing vCategory tests at line 335.
  • test_vweekday_rejects_invalid_jcal_value belongs in src/icalendar/tests/prop/test_vWeekday.py.
  • test_vdate_rejects_invalid_calendar_date belongs in src/icalendar/tests/prop/test_date_and_time.py.

Once you've moved them, this new file can be deleted.

@karurukaruru karurukaruru Aug 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the detailed guidance. I have moved each test to the existing test file you suggested and removed src/icalendar/tests/prop/test_issue_698_more_coverage.py. I also ran the five affected tests and the Ruff lint and formatting checks, and they pass. I appreciate your help in showing me the project's preferred test organization.

AI disclosure: I used OpenAI Codex (GPT-5.6) to apply the requested test organization changes, review the diff, and verify formatting and the five affected tests.

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I will wait for Sashank to have a look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants