Add RESOURCES property, update REQUEST-STATUS and REFIDS property docstring - #1696
Add RESOURCES property, update REQUEST-STATUS and REFIDS property docstring#1696SemTiOne wants to merge 27 commits into
Conversation
|
This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments. |
|
Profile summary: Full profile |
c319590 to
a3751b9
Compare
Add RESOURCES property (RFC 5545 §3.8.1.10) to Event and Todo via multi_string_property. Includes new() param, parametrized tests. AI disclosure: used Claude Sonnet 5 with prompt "Implement RESOURCES property per RFC 5545 §3.8.1.10 using multi_string_property pattern. Add getter/setter/ deleter, new() params, tests for Event and Todo."
a3751b9 to
17daca9
Compare
niccokunzmann
left a comment
There was a problem hiding this comment.
Technically sound! Thanks!
I will wait for the documentation review.
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
stevepiercy
left a comment
There was a problem hiding this comment.
Excellent work! I suggested a rewrite of the news fragment, and asked a couple of questions about tests and functionality. Would you please take care? Thank you!
Co-authored-by: Steve Piercy <web@stevepiercy.com>
niccokunzmann
left a comment
There was a problem hiding this comment.
A small request: Could you move the test file into tests/attr?
I try to gather all tests there - if you feel like it, that is a contribution for a new PR to move these tests for the attr.py content into that directory.
Also: It seems to me like you are really good at writing documentation... I invite you to have a look at the code in attr.py: #1244 clearly says that the way I approached documentation by copy&paste from the RFC is now obsolete and the way you write it now is much better.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
This is much clearer to me. Thank you! Please take a look, and let me know.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
Copy the note, and I approve. Thank you!
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
@SemTiOne Let us know when we should have a look again! |
stevepiercy
left a comment
There was a problem hiding this comment.
Good to copy the note to other multi_string_property properties.
However, the addition to categories should be handled in #1722.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
@niccokunzmann would you please do a final review? |

Linked issue
Description
Add RESOURCES property (RFC 5545 §3.8.1.10) to Event and Todo via
multi_string_property. Includes new() param, parametrized tests. Also updated REQUEST-STATUS property docstring.Checklist