Skip to content

Add RESOURCES property, update REQUEST-STATUS and REFIDS property docstring - #1696

Open
SemTiOne wants to merge 27 commits into
collective:mainfrom
SemTiOne:issue-1667-resources-property
Open

Add RESOURCES property, update REQUEST-STATUS and REFIDS property docstring#1696
SemTiOne wants to merge 27 commits into
collective:mainfrom
SemTiOne:issue-1667-resources-property

Conversation

@SemTiOne

@SemTiOne SemTiOne commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Linked issue

Description

Add RESOURCES property (RFC 5545 §3.8.1.10) to Event and Todo via multi_string_property. Includes new() param, parametrized tests. Also updated REQUEST-STATUS property docstring.

Checklist

  • I added a change log entry, following the instructions in Change log entry format.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

@github-actions github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments.

@github-actions

Copy link
Copy Markdown
Contributor

Profile summary:

GitHub user: SemTiOne
🟢 No concerns found with user's profile.
🟢 No concerns found with recent PR activity.
🟢 No concerns found with recent issue activity.

For a more detailed report, run `gh-profiler SemTiOne`.
Full profile
GitHub user: SemTiOne
🟢 No concerns found with user's profile.
   🟢 Account age: 1 year, 2 months
   🟢 Profile information:
        name: Dane Parin
        email: emphyst80@gmail.com
        bio: Backend & DevOps Engineer · CLI tools, databases, automations · Python, Java, C++, Docker, MySQL
        twitter: https://x.com/DParin28178
        bluesky: https://bsky.app/profile/daneparin.bsky.social
      Empty fields: company, blog, location

🟢 No concerns found with recent PR activity.
   40 PRs opened in the last 21 days.
      2 opened against repos the user owns.
      0 opened against repos in publicly associated orgs.
      38 opened against external repos.

   🟢 30 of 38 external PRs merged in the last 21 days.
   🟢 3 of 38 external PRs closed without merging in the last 21 days.

🟢 No concerns found with recent issue activity.
   20 new issues opened in the last 21 days.
      0 opened in repos the user owns.
      0 opened in repos in publicly associated orgs.
      20 opened in external repos.

   🟢 2 external issues closed as NOT_PLANNED.
   🟢 0 external issues opened with the same title.

@read-the-docs-community

read-the-docs-community Bot commented Aug 19, 2026

Copy link
Copy Markdown

@SemTiOne
SemTiOne force-pushed the issue-1667-resources-property branch from c319590 to a3751b9 Compare August 19, 2026 16:16
   Add RESOURCES property (RFC 5545 §3.8.1.10) to Event and Todo via
   multi_string_property. Includes new() param, parametrized tests.

   AI disclosure: used Claude Sonnet 5 with prompt "Implement RESOURCES property
   per RFC 5545 §3.8.1.10 using multi_string_property pattern. Add getter/setter/
   deleter, new() params, tests for Event and Todo."
@SemTiOne
SemTiOne force-pushed the issue-1667-resources-property branch from a3751b9 to 17daca9 Compare August 19, 2026 16:20

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically sound! Thanks!

I will wait for the documentation review.

Comment thread src/icalendar/attr.py
Comment thread src/icalendar/tests/test_issue_843_new_method_for_components.py Outdated
@SemTiOne
SemTiOne requested a review from niccokunzmann August 20, 2026 03:37

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I suggested a rewrite of the news fragment, and asked a couple of questions about tests and functionality. Would you please take care? Thank you!

Comment thread news/1667.feature Outdated
Comment thread src/icalendar/tests/test_issue_843_new_method_for_components.py
Comment thread src/icalendar/tests/attr/test_resources.py
Comment thread src/icalendar/tests/attr/test_resources.py
Comment thread src/icalendar/tests/attr/test_resources.py
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@SemTiOne
SemTiOne requested a review from stevepiercy August 20, 2026 06:05
Comment thread src/icalendar/attr.py Outdated
niccokunzmann
niccokunzmann previously approved these changes Aug 21, 2026

@niccokunzmann niccokunzmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small request: Could you move the test file into tests/attr?

I try to gather all tests there - if you feel like it, that is a contribution for a new PR to move these tests for the attr.py content into that directory.

Also: It seems to me like you are really good at writing documentation... I invite you to have a look at the code in attr.py: #1244 clearly says that the way I approached documentation by copy&paste from the RFC is now obsolete and the way you write it now is much better.

@SemTiOne

Copy link
Copy Markdown
Contributor Author
Done

@SemTiOne
SemTiOne requested a review from niccokunzmann August 21, 2026 15:46
@SemTiOne SemTiOne changed the title Add RESOURCES property Add RESOURCES property and update REQUEST-STATUS property docstring Aug 24, 2026

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer to me. Thank you! Please take a look, and let me know.

Comment thread src/icalendar/attr.py Outdated
Co-authored-by: Steve Piercy <web@stevepiercy.com>

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy the note, and I approve. Thank you!

Comment thread src/icalendar/attr.py Outdated
SemTiOne and others added 2 commits August 24, 2026 15:59
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@SemTiOne SemTiOne changed the title Add RESOURCES property and update REQUEST-STATUS property docstring Add RESOURCES property, update REQUEST-STATUS and REFIDS property docstring Aug 24, 2026
@SemTiOne
SemTiOne requested a review from stevepiercy August 24, 2026 09:07
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 97.514% (+0.007%) from 97.507% — SemTiOne:issue-1667-resources-property into collective:main

@niccokunzmann

Copy link
Copy Markdown
Member

@SemTiOne Let us know when we should have a look again!

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to copy the note to other multi_string_property properties.

However, the addition to categories should be handled in #1722.

Comment thread src/icalendar/attr.py Outdated
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@SemTiOne
SemTiOne requested a review from stevepiercy August 25, 2026 00:52
stevepiercy
stevepiercy previously approved these changes Aug 25, 2026

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stevepiercy

Copy link
Copy Markdown
Member

@niccokunzmann would you please do a final review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RESOURCES property

4 participants