Add new() method to vCalAddress class (fixes #870)#882
Merged
niccokunzmann merged 5 commits intoJul 22, 2025
Merged
Conversation
Member
Author
|
All requirements from Issue #870 implemented. Ready for merge. |
Pull Request Test Coverage Report for Build 16389578345Details
💛 - Coveralls |
Member
Author
|
Looking into the nopytz test failure. |
- Add case-insensitive mailto: prefix handling with static helper method - Implement comprehensive parametrized test structure as suggested - Fix error type from AttributeError to TypeError - Add static _get_email() method to avoid code duplication - Support all RFC 5545 parameters with automatic mailto: handling - Integration confirmed with Event.new() attendees parameter - Comprehensive test coverage with 36 test cases
Member
Author
|
Ready for merge
Implementation complete for #870 |
Member
Author
|
@niccokunzmann Could you please review and merge when ready? This would help me continue work on PR #881 without merge conflicts. |
Member
|
Thanks, this is nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the method for the class to provide a consistent API with other icalendar components like .
Changes Made
✅ vCalAddress.new() method implementation:
✅ Comprehensive test suite:
✅ Documentation:
Example Usage
Testing
All tests pass (25/25) and maintain backward compatibility.
Fixes #870
📚 Documentation preview 📚: https://icalendar--882.org.readthedocs.build/