-
-
Notifications
You must be signed in to change notification settings - Fork 184
added ics_value property to vPeriod, vDuration,vDate,vText #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@TejasR002 Tests are failing. Let me know when this is ready for a review. Edit: It looks like this branch is behind Edit 2: The PR body still has the default template. Could you update it with details about your implementation? For example, explain how the new |
|
@TejasR002, thank you for opening the PR! @SashankBhamidi, I will assign this to you, please help @TejasR002 to go through all the hurdles and checks. I will refine the issue now. @TejasR002, let us know if you need any help or guidance - it is a big project :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I left a comment inline. For this PR, it is enough to add ics_value to a few classes and get it merged. No need to add it to all of them. You can open more pull requests for others once this is merged :) Thank you for taking this on!
| @property | ||
| def ics_value(self): | ||
| if self.by_duration: | ||
| return (self.start, self.duration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates .dt. Please just return self.dt.
Also, they all need a type hint in the end. I updated the issue to be clearer on the scope.
|
@TejasR002 Let me know if you need help with anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think for now, it would be ok to remove the changes in this file here. Then, the tests should pass. There are a lot of classes that will receive the .ics_value property. Adding some is a good first contribution. Embedding that behaviour into icalendar might be too hard for a first-time contribution. If you remove the changes in this file and add tests for the existing new .ics_value properties, that is a really great contribution!
|
I corrected the issue: it is now called |
Closes issue
Description
added ics_value property to vPeriod, vDuration,vDate,vText.
Checklist
CHANGES.rst.docs/credits.rstas a contributor in this pull request or have done so previously.Additional information
Upload screenshots, videos, links to documentation, or any other relevant information.
📚 Documentation preview 📚: https://icalendar--916.org.readthedocs.build/