Skip to content

Conversation

@niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Oct 26, 2025

Closes issue

Replace ISSUE_NUMBER with the issue number that your pull request fixes. Then GitHub will link and automatically close the related issue.

Description

This intends to solve the issue

Checklist

  • add parameter types "# parameter types (luckily there is no name overlap)"
  • add to new()
  • figure out why the type hints do not work for the properties like Event.conferences and Event.links
  • I've added a change log entry to CHANGES.rst.
  • I've added or updated tests if applicable.
  • I've run and ensured all tests pass locally by following Running Tests.
  • I've added or edited documentation, both as docstrings to be rendered in the API documentation and narrative documentation, as necessary.
  • I've added myself to docs/credits.rst as a contributor in this pull request or have done so previously.

Still TODO:

Documentation Review guidance

Classes modified:

Additional information

www.rfc-editor.org/rfc/rfc9253.html

@coveralls
Copy link

coveralls commented Oct 26, 2025

Pull Request Test Coverage Report for Build 19035348858

Details

  • 462 of 464 (99.57%) changed or added relevant lines in 23 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/attr.py 72 74 97.3%
Totals Coverage Status
Change from base Build 19034014329: 0.07%
Covered Lines: 8551
Relevant Lines: 8722

💛 - Coveralls

@niccokunzmann niccokunzmann changed the title Add vLink Add RFC 9253 compatibility Oct 26, 2025
@niccokunzmann niccokunzmann marked this pull request as ready for review October 30, 2025 15:50
@niccokunzmann
Copy link
Member Author

This is ready for review when you have time. No pressure ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 9253 - iCalendar Relationships

2 participants