Switch to PEP 420 native namespaces #491
Conversation
There was a problem hiding this comment.
I made a few minor changes. For example we do need to call find_namespace_packages in setup.py.
Why did you change the minimum required Python to 3.11? Did you hear a rumour somewhere? I am not planning to change it, it should just be 3.10. I have updated the branch.
In .meta.toml we should add some lines for good measure:
[tox]
constraints_file = "https://dist.plone.org/release/6.2-ev/constraints.txt"
But then we would need to call plone/meta on it, which makes too many changes.
No, sorry, I wanted to update it to the actual version, and thought that it was 3.10. |
mauritsvanrees
force-pushed
the
plone-62
branch
from
31b0f38 to
a46869e
Compare
Perfect, that's why this is a draft PR |
`tox -e dependencies` complained:
```
Missing requirements
====================
i18ndude.catalog
utils.PRODUCTS
utils.getLanguage
utils.getLongProductName
utils.getPoFiles
utils.getPoFilesAsCmdLine
utils.getPoFilesByLanguageCode
utils.getPotFiles
utils.getProduct
utils.getProductPath
```
This indicates that our top level `utils` directory is regarded as a package, which it should not.
You already see this a bit in coredev 6.1, where our `utils` module is unnecessarily available:
```
$ bin/zopepy
>>> import utils
>>> utils
<module 'utils' (namespace) from ['/Users/maurits/community/plone-coredev/6.1/src/plone.app.locales/utils']>
```
The same happens for `docs` and `news` in multiple packages:
```
>>> import docs
>>> docs
<module 'docs' (namespace) from [
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.caching/docs',
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.locales/docs',
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.upgrade/docs',
'/Users/maurits/community/plone-coredev/6.1/src/Products.CMFPlone/docs']>
>>> import news
>>> news
<module 'news' (namespace) from [
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.caching/news',
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.locales/news',
'/Users/maurits/community/plone-coredev/6.1/src/plone.app.upgrade/news',
'/Users/maurits/community/plone-coredev/6.1/src/plone.schema/news',
'/Users/maurits/community/plone-coredev/6.1/src/Products.CMFPlone/news']>
```
So it is nothing new, we are already doing something wrong and nothing bad really happens, but let's gradually improve. :-)
No description provided.