Skip to content

fix: removed unused prevent click#9

Open
sabrina-bongiovanni wants to merge 2 commits intomasterfrom
prevent_click_prevents_checkbox_on_change
Open

fix: removed unused prevent click#9
sabrina-bongiovanni wants to merge 2 commits intomasterfrom
prevent_click_prevents_checkbox_on_change

Conversation

@sabrina-bongiovanni
Copy link
Member

The preventClick function set on all form prevents checkbox onChange to have effects.

Same issue as collective/volto-dropdownmenu#36

The problem is that the click is not applied to the component. No onChange function at any level is even triggered, which means that it is not a id problem or a onChange function problem, but the fact that the click does not trigger anything inside the component.

This does not happen on other widgets because the components (text input, buttons, etc.) intercept the click before the preventClick does as it does not propagate.
Since it seems there is actually no need for a preventClick function, I would just remove it and keep the preventEnter as it is the one that prevents the real risk of submitting the form.

I guessed preventClick was introduced to avoid any submissions of the form, but removing it does not seem to change anything besides making the Checkbox work.
We tried to

change menu item
change menu navigation tab
remove or add item menus to the same tab
remove or add tabs to the navigation tabs
changing other fields
the network tab does not show any submits nor the form seems to have any issues.

@sabrina-bongiovanni sabrina-bongiovanni self-assigned this Feb 17, 2026
@sabrina-bongiovanni sabrina-bongiovanni added the bug Something isn't working label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments