Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preventClick function set on all form prevents checkbox onChange to have effects.
Same issue as collective/volto-dropdownmenu#36
The problem is that the click is not applied to the component. No onChange function at any level is even triggered, which means that it is not a id problem or a onChange function problem, but the fact that the click does not trigger anything inside the component.
This does not happen on other widgets because the components (text input, buttons, etc.) intercept the click before the preventClick does as it does not propagate.
Since it seems there is actually no need for a preventClick function, I would just remove it and keep the preventEnter as it is the one that prevents the real risk of submitting the form.
I guessed preventClick was introduced to avoid any submissions of the form, but removing it does not seem to change anything besides making the Checkbox work.
We tried to
change menu item
change menu navigation tab
remove or add item menus to the same tab
remove or add tabs to the navigation tabs
changing other fields
the network tab does not show any submits nor the form seems to have any issues.