Skip to content

Conversation

@Tishasoumya-02
Copy link
Collaborator

@Tishasoumya-02 Tishasoumya-02 commented Aug 31, 2025

Changes for workflow tab can be saved. @Manas-Kenge ,you can see this example and implement the same for other tabs.

Things to keep in mind:

  1. Look in Form.jsx component for what props it accepts and how it is used . In form you were implementing onChangeField but use onChangeFormData instead.
  2. Don't use useCallbacks unnecessarily , no need to use them for save/data change.
  3. And if you are disabling a button , make sure that the color is off for the disabled button. ( I have to look out for why the button was not working, if it was disabled and it was visible then it would have been easier.)
  4. I have some console logs in place you can see how the existing logic works.
  5. Delete works.

If you get stuck somewhere , create a PR.

Changes I have made

  1. Removed the react-spectrum Tabs, it was not letting classes assigned and was not functioning well and out of design too, I re-instated the volto sidebar with it's css , which means we need to import from semantic-UI which is an exception in our case.
  2. Now the sidebar overlapping issue should also be solved
  3. You can remove any css which was forcing any margins etc in the sidebar.
  4. Is there any way of removing assign content-types?
  5. We will keep using forms , no need to use BlockDataForm

@Tishasoumya-02 Tishasoumya-02 changed the base branch from main to test-1 August 31, 2025 11:21
@Tishasoumya-02
Copy link
Collaborator Author

I have merge conflicts on this branch , will need to remove it

@Tishasoumya-02
Copy link
Collaborator Author

Tishasoumya-02 commented Aug 31, 2025 via email

@Manas-Kenge
Copy link
Collaborator

Help me understand a few things:

  1. Wasn't the main reason for using React Spectrum to move away from the old Volto UI and be closer to 'seven'? If we are also using Semantic UI, that means we’re now using three component libraries — React Spectrum, Semantic UI, and native Volto components.
  2. The sidebar overlapping issue still hasn’t been fixed.
  3. There’s currently no way to remove assigned content types, but my question is — should this even be part of the workflow manager? I feel like there might be a better and more sophisticated way to handle this somewhere else, maybe in the backend. In the older workflow manager, it was part of a view that extended the workflow manager, which I think we shouldn’t include here. We can confirm this with Rafael.
  4. When you switch from the /edit page sidebar to the workflow sidebar, you see the "Plone site" tab instead of the "Workflow" tab. You need to refresh the page to fix it.
  5. When you make changes in the state or transition tab in the form, it causes an infinite render. I’m not sure why this is happening now but not before.
  6. I have one more doubt which I have been meaning to ask you before, how can I change the browser tab label to something like 'workflow manager'? It currently says 'site setup'
image

@Tishasoumya-02
Copy link
Collaborator Author

For showing workflow-manager instead of site-setup in the browser label tap. Add Helmet helper component to WorkflowPanel component . For example https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Controlpanels/Relations/Relations.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants