Skip to content

Add ruby3.4 and rails8.1 to the CI matrix #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
willnet wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add ruby3.4 and rails8.1 to the CI matrix #768

willnet wants to merge 4 commits into from

Conversation

@willnet
Copy link

@willnet willnet commented Dec 10, 2025 •
edited
Loading

  • Add Ruby 3.4 and Rails 8.1 to the CI matrix and fixed all failing tests
  • Upgrade actions/update to the latest version
  • CI result is here

@willnet
Add Ruby3.4 and Rails8.1 to CI matrix
f7dca53
@willnet
Fix test failures when running the test suite on Rails 6.0 and 6.1
c810a76 
The following error was occurring:

```
NameError:
  uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger
```

Resolved the issue by using concurrent-ruby versions below 1.3.5.

ref: [uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError) on Rails 7.0.8.7 and concurrent-ruby 1.3.5 · Issue #54271 · rails/rails](rails/rails#54271)
@willnet
Fix a failing test caused by the inspect format change in Ruby 3.4
989561f 
From Ruby 3.4, the output format of inspect has changed as follows:

```ruby
# Ruby < 3.4
{foo: "bar"}.inspect #=> {:foo=>"bar"}

# Ruby 3.4
{foo: "bar"}.inspect #=> "{foo: \"bar\"}"
```

Because of this change, running the tests on Ruby 3.4 caused the following failure, so I updated the test to handle different behavior depending on the Ruby version.

```
  1) Audited::Audit#audited_changes does not unserialize from binary columns
     Failure/Error: expect(audit.audited_changes).to eq "{:foo=>\"bar\"}"

       expected: #<Encoding:UTF-8> "{:foo=>\"bar\"}"
            got: #<Encoding:US-ASCII> "{foo: \"bar\"}"

       (compared using ==)
     # ./spec/audited/audit_spec.rb:75:in 'block (3 levels) in <top (required)>'
```
@willnet
Upgrade actions/checkout to the latest version
7c04215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@willnet