Fix Rails 7.2 deprecation warning for ActiveRecord::Base.connection - #251
Open
benaitcheson wants to merge 1 commit into
Open
Fix Rails 7.2 deprecation warning for ActiveRecord::Base.connection#251benaitcheson wants to merge 1 commit into
benaitcheson wants to merge 1 commit into
Conversation
Author
|
@danielmorrison / @albus522 if you have a moment, could I please get a review on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.2 soft-deprecated
ActiveRecord::Base.connectionin favour oflease_connection(rails/rails#51230). The bareconnectioncalls in the reservation code paths trigger this warning on every job reservation:This adds a
reservation_connectionhelper that useslease_connectionwhere available and falls back toconnectionon older Rails versions, keeping compatibility with the full supported ActiveRecord range. Same approach as #218 and #226 for earlier deprecations.lease_connectionreturns the same leased-per-thread connection thatconnectiondid, so behaviour is unchanged.