Optionally exclude queues by worker - #74
Open
adamonduty wants to merge 2 commits into
Open
Conversation
|
Changes Unknown when pulling 1289acd on adamonduty:exclude_queues into * on collectiveidea:master*. |
|
👍 |
|
I've created a fork for a purpose similar to this with the notable difference that the query is ready_scope = ready_scope.where('queue NOT IN (?) OR queue IS NULL', Worker.except_queues)In order to pick up nameless queue jobs which would be restricted from the not in query comparing to nil, but would still make sense in an 'except queue' workflow imo. |
Author
|
@derekrockwell Looks good to me! I did the same and pushed the branch. |
sferik
force-pushed
the
master
branch
2 times, most recently
from
October 8, 2014 16:39
b3f2a9b to
b3adaee
Compare
sferik
force-pushed
the
master
branch
2 times, most recently
from
December 22, 2014 17:16
1240e8d to
639c9e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an another attempt at pull #28 with tests (credit to @arjes for tracking down the code change). It also should be compatible with current/previous versions of DJ by using
respond_to?. Assuming this pull is acceptable, I'll submit another to DJ proper to add the cli options.