Skip to content

Optionally exclude queues by worker - #74

Open
adamonduty wants to merge 2 commits into
collectiveidea:masterfrom
adamonduty:exclude_queues
Open

Optionally exclude queues by worker#74
adamonduty wants to merge 2 commits into
collectiveidea:masterfrom
adamonduty:exclude_queues

Conversation

@adamonduty

Copy link
Copy Markdown

This is an another attempt at pull #28 with tests (credit to @arjes for tracking down the code change). It also should be compatible with current/previous versions of DJ by using respond_to?. Assuming this pull is acceptable, I'll submit another to DJ proper to add the cli options.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 1289acd on adamonduty:exclude_queues into * on collectiveidea:master*.

@derekrockwell

Copy link
Copy Markdown

👍

@derekrockwell

Copy link
Copy Markdown

I've created a fork for a purpose similar to this with the notable difference that the query is

ready_scope = ready_scope.where('queue NOT IN (?) OR queue IS NULL', Worker.except_queues)

In order to pick up nameless queue jobs which would be restricted from the not in query comparing to nil, but would still make sense in an 'except queue' workflow imo.

@adamonduty

Copy link
Copy Markdown
Author

@derekrockwell Looks good to me! I did the same and pushed the branch.

@sferik
sferik force-pushed the master branch 2 times, most recently from b3f2a9b to b3adaee Compare October 8, 2014 16:39
@sferik
sferik force-pushed the master branch 2 times, most recently from 1240e8d to 639c9e5 Compare December 22, 2014 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants