Fix for reading extended frames without filters #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lbox filter is unused
…lbox filter is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was unable to receive extended CAN frames, with the existing initialization and default filter masking.
The MK66 datasheet, page 1749, footnote three indicates that unless EACEN is set to 1, we won't be able to pass extended frames.
"If the CTRL2[EACEN] bit is negated, the IDE bit of Mailbox is always compared with the IDE bit of the incoming frame."
The assignment of default masking for each MB is 0, only standard IDs may pass. Setting CTRL2[EACEN] to 1 bypasses this comparison problem and allows standard and extended IDs through with the default masking scheme, as I believe is intended.
I tested this transmitting and receiving both extended and standard IDs. Before this change, only standard IDs would pass, after both standard and extended IDs would pass. I did not test any message filtering with specific mailboxes.