Skip to content

Commit f2366e1

Browse files
committed
add more points in the unit test
1 parent db5bb79 commit f2366e1

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

glomap/controllers/rotation_averager_test.cc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ void ExpectEqualGravity(
120120
TEST(RotationEstimator, WithoutNoise) {
121121
const std::string database_path = colmap::CreateTestDir() + "/database.db";
122122

123-
// FLAGS_v = 2;
124123
colmap::Database database(database_path);
125124
colmap::Reconstruction gt_reconstruction;
126125
colmap::SyntheticDatasetOptions synthetic_dataset_options;
@@ -166,7 +165,6 @@ TEST(RotationEstimator, WithNoiseAndOutliers) {
166165
synthetic_dataset_options.num_cameras = 2;
167166
synthetic_dataset_options.num_images = 7;
168167
synthetic_dataset_options.num_points3D = 100;
169-
// synthetic_dataset_options.point2D_stddev = 0.5;
170168
synthetic_dataset_options.point2D_stddev = 1;
171169
synthetic_dataset_options.inlier_match_ratio = 0.6;
172170
colmap::SynthesizeDataset(
@@ -208,7 +206,7 @@ TEST(RotationEstimator, RefineGravity) {
208206
colmap::SyntheticDatasetOptions synthetic_dataset_options;
209207
synthetic_dataset_options.num_cameras = 2;
210208
synthetic_dataset_options.num_images = 100;
211-
synthetic_dataset_options.num_points3D = 50;
209+
synthetic_dataset_options.num_points3D = 200;
212210
synthetic_dataset_options.point2D_stddev = 0;
213211
colmap::SynthesizeDataset(
214212
synthetic_dataset_options, &gt_reconstruction, &database);
@@ -220,7 +218,6 @@ TEST(RotationEstimator, RefineGravity) {
220218

221219
ConvertDatabaseToGlomap(database, view_graph, cameras, images);
222220

223-
// PrepareRelativeRotations(view_graph, images);
224221
PrepareGravity(
225222
gt_reconstruction, images, /*stddev_gravity=*/0., /*outlier_ratio=*/0.3);
226223

glomap/estimators/view_graph_calibration.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ size_t ViewGraphCalibrator::FilterImagePairs(ViewGraph& view_graph) const {
179179
}
180180

181181
LOG(INFO) << "invalid / total number of two view geometry: "
182-
<< invalid_counter << " / " << counter;
182+
<< invalid_counter << " / " << (counter / 2);
183183

184184
return invalid_counter;
185185
}

0 commit comments

Comments
 (0)