Use CMAKE_CURRENT_SOURCE_DIR in FindDependencies.cmake#175
Merged
lpanaf merged 1 commit intocolmap:mainfrom Mar 20, 2025
Merged
Use CMAKE_CURRENT_SOURCE_DIR in FindDependencies.cmake#175lpanaf merged 1 commit intocolmap:mainfrom
lpanaf merged 1 commit intocolmap:mainfrom
Conversation
ahojnnes
approved these changes
Mar 13, 2025
Contributor
Author
|
@ahojnnes Is the CI stuck on this change? I see a number of pending checks that don't appear to be making progress. |
uptycs-rmack
pushed a commit
to uptycs-rmack/glomap
that referenced
this pull request
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_SOURCE_DIRrefers to the root of the project, whileCMAKE_CURRENT_SOURCE_DIRrefers to the directory from whichFindDependencies.cmakewas included (theglomapdir).CMAKE_SOURCE_DIRwill break when glomap is built as part of a larger CMake project.CMAKE_CURRENT_SOURCE_DIRbehaves correctly in this context.