Add Tests to verify the count of colors returned matches the count requested #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to let you know that for values of count greater than 7, the actual number of colors returned is one fewer than the requested count.
I added tests here to automate checking for the issue. The first two tests pass, and the final test fails:
Uncaught AssertionError [ERR_ASSERTION]: 9 == 10I've debugged the cause:
The count that is received by quantize is considered a maximum count, but in get-image-colors and get-rgba-palette, we treat it as THE count.
I think quantize should be able to better guarantee the actual colors returned matches the count requested, so I opened an Issue and a Pull Request against them:
olivierlesnicki/quantize#10