fix(hooks): route forwarded test args to vitest + ROADMAP refresh - #75
Merged
Conversation
The `test` script chained `... && vitest --run && tsd`, so trailing args from `pnpm test -- <args>` landed on `tsd` (which silently ignores them) instead of the test runner — e.g. `pnpm test -- -t <name>` did not filter. Reorder so `vitest` is last; add a `test:types` script for running tsd alone. CI's arg-free `pnpm test` still runs build + tsd + vitest. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Refresh package versions to the published set (hooks 3.12.0, components 4.6.1, react 4.1.11), record the 2026-06-09 work in Recently shipped, and clear the now-empty Planned / Known-issues sections. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm testarg-forwardingThe hooks
testscript chainedpnpm -w -r build && vitest --run && tsd, so trailing args frompnpm test -- <args>landed ontsd(last in the chain), which silently ignores them — they never reached the test runner. Sopnpm test -- -t "useWatch"ran all tests, not the filtered set.Finding: the ROADMAP described this as "
pnpm test -- --runexits non-zero," but that no longer reproduces — the currenttsd(0.31.x) tolerates unknown flags, so the chain exits 0. The real, remaining papercut is that forwarded args don't reachvitest.Fix: reorder so
vitestis last (build && tsd && vitest --run), and add atest:typesscript for runningtsdalone. CI's arg-freepnpm teststill runs build + tsd + vitest.Verified:
ROADMAP refresh
Brings
ROADMAP.mdcurrent after the last few merges:hooks 3.12.0,components 4.6.1,react 4.1.11).No changeset — dev-tooling + docs only; the
testscript isn't consumer-facing.🤖 Generated with Claude Code