Skip to content

fix(hooks): route forwarded test args to vitest + ROADMAP refresh - #75

Merged
colorpulse6 merged 2 commits into
mainfrom
fix/hooks-test-arg-forwarding
Jun 9, 2026
Merged

fix(hooks): route forwarded test args to vitest + ROADMAP refresh#75
colorpulse6 merged 2 commits into
mainfrom
fix/hooks-test-arg-forwarding

Conversation

@colorpulse6

Copy link
Copy Markdown
Owner

pnpm test arg-forwarding

The hooks test script chained pnpm -w -r build && vitest --run && tsd, so trailing args from pnpm test -- <args> landed on tsd (last in the chain), which silently ignores them — they never reached the test runner. So pnpm test -- -t "useWatch" ran all tests, not the filtered set.

Finding: the ROADMAP described this as "pnpm test -- --run exits non-zero," but that no longer reproduces — the current tsd (0.31.x) tolerates unknown flags, so the chain exits 0. The real, remaining papercut is that forwarded args don't reach vitest.

Fix: reorder so vitest is last (build && tsd && vitest --run), and add a test:types script for running tsd alone. CI's arg-free pnpm test still runs build + tsd + vitest.

Verified:

$ pnpm --filter el-form-react-hooks test -- -t "useWatch"
  Test Files  1 passed | 22 skipped (23)
       Tests  9 passed | 107 skipped (116)     # ← now filters; exit 0

ROADMAP refresh

Brings ROADMAP.md current after the last few merges:

  • Package versions → the published set (hooks 3.12.0, components 4.6.1, react 4.1.11).
  • Records useWatch, CI Node 24 actions, and this test fix under Recently shipped.
  • Clears the now-empty Planned and Known issues sections (no open feature/correctness/tooling items remain).

No changeset — dev-tooling + docs only; the test script isn't consumer-facing.

🤖 Generated with Claude Code

colorpulse6 and others added 2 commits June 9, 2026 14:01
The `test` script chained `... && vitest --run && tsd`, so trailing args from
`pnpm test -- <args>` landed on `tsd` (which silently ignores them) instead of
the test runner — e.g. `pnpm test -- -t <name>` did not filter. Reorder so
`vitest` is last; add a `test:types` script for running tsd alone. CI's arg-free
`pnpm test` still runs build + tsd + vitest.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Refresh package versions to the published set (hooks 3.12.0, components 4.6.1,
react 4.1.11), record the 2026-06-09 work in Recently shipped, and clear the
now-empty Planned / Known-issues sections.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@colorpulse6
colorpulse6 merged commit 205e8fc into main Jun 9, 2026
8 checks passed
@colorpulse6
colorpulse6 deleted the fix/hooks-test-arg-forwarding branch June 9, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant