feat(hooks): add isSubmitted/isSubmitSuccessful/submitCount to formState - #82
Merged
Conversation
RHF-parity submit-status fields, set consistently across handleSubmit, submit(), and submitAsync(): isSubmitted (true after first attempt), submitCount (per attempt), isSubmitSuccessful (true only when validation passed AND the handler ran without throwing). All reset by reset()/resetValues()/restoreSnapshot(). 7 runtime tests (valid/invalid submit, handleSubmit, count increment, reset, throwing-handler) + updated 2 unit-test fixtures for the new required fields. Additive, minor. (isValidating + reactive dirtyFields are the fast-follow.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
github-actions
Bot
added
the
ready to publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap item P2 (first slice) —
formStatecompleteness. Adds the most commonly-used React Hook Form status fields el-form was missing:isSubmittedsubmitCountisSubmitSuccessfulAll three are reset by
reset()(andresetValues/restoreSnapshot), and set consistently acrosshandleSubmit,submit(), andsubmitAsync().Implementation
FormStatetype; defaults at the four full-FormStatecreation sites; set insubmitOperations(start:isSubmitted: true,submitCount: prev+1,isSubmitSuccessful: false; on success:isSubmitSuccessful: trueafter the handler resolves — if it throws, that line is skipped so it stays false).setFormStateupdaters inherit the new fields automatically.Verification
submit(), invalidsubmit()(success stays false),handleSubmitpath, count increment, throwing-handler (success false, count still increments, rejection propagates), andreset()clearing.Additive minor (
el-form-react-hooks);el-form-reactpicks it up via dependent bump. Fast-follow (P2b):isValidating+ a reactivedirtyFieldsfield.🤖 Generated with Claude Code