Fix exception when printing some warnings #1706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
In more detail, we get the following in Scala 2.13 and the following in Scala 2.12 (different invalid array index) |
Not sure why, this warning's position is a RangePosition (with a start, an end, and a "point" that may lie outside of the [start,end] range), and its point value doesn't get offset by the LineNumberModifier plugin. This makes Position.formatError throw an ArrayIndexOutOfBoundException if we don't fix that point value ourselves.
alexarchambault
force-pushed
the
fix-position-crash
branch
from
84a5a34 to
13381bf
Compare
Collaborator
Author
lolgab
reviewed
Jan 13, 2026
| def mvnDeps: T[Seq[Dep]] = super.mvnDeps() ++ amm.compiler().mvnDeps() ++ Seq( | ||
| Deps.scalazCore | ||
| Deps.scalazCore, | ||
| Deps.coursierVersions(scalaVersion()) |
Member
There was a problem hiding this comment.
I don't see how this change is related to the position fix.
Can you help me?
Collaborator
Author
There was a problem hiding this comment.
The dependency is only added in the tests of the repl module. I use it to compare Scala versions (some test data is different up to 2.12.12 vs after it), rather than flaky hand made version comparison.
alexarchambault
commented
Jan 13, 2026
|
|
||
| def fixPos(pos: Position): Position = | ||
| pos match { | ||
| case r: RangePosition if r.point > r.source.length && r.point - importsLen >= 0 && r.point - importsLen <= r.source.length => |
Collaborator
Author
There was a problem hiding this comment.
This is kind of a hack. This substracts importsLen when it feels it's the right thing to do (point is higher than the source length, and offsetting importsLen from it brings it back into the source).
Collaborator
Author
lolgab
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why, the position of the warning in the added test is a
RangePosition(with a start, an end, and a "point" that may lie outside of the [start,end] range), and its point value doesn't get offset by theLineNumberModifierplugin. This makesPosition.formatErrorthrow anIndexOutOfBoundsExceptionif we don't fix that point value ourselves.