Make repl.load accept raw sources starting with package directive#1710
Merged
alexarchambault merged 3 commits intoJan 22, 2026
Merged
Conversation
alexarchambault
force-pushed
the
eval-package-cell
branch
from
b1f84c0 to
464a81a
Compare
Collaborator
Author
|
Don't know if anyone feels like reviewing / approving this. This is just a followup of #1684. |
Member
|
Looks good to me |
Collaborator
Author
@lihaoyi Seems a (GitHub UI) approval is needed to merge 😅 |
Collaborator
Author
lolgab
approved these changes
Jan 22, 2026
alexarchambault
force-pushed
the
eval-package-cell
branch
from
f16529f to
e9c3807
Compare
LuciferYang
pushed a commit
to apache/spark
that referenced
this pull request
Feb 13, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `ammonite` to 3.0.8 for Apache Spark 4.2.0. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.6 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.7 - com-lihaoyi/Ammonite#1706 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.8 - com-lihaoyi/Ammonite#1710 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes #54305 from dongjoon-hyun/SPARK-55514. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: yangjie01 <yangjie01@baidu.com>
a0x8o
added a commit
to a0x8o/spark
that referenced
this pull request
Feb 13, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `ammonite` to 3.0.8 for Apache Spark 4.2.0. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.6 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.7 - com-lihaoyi/Ammonite#1706 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.8 - com-lihaoyi/Ammonite#1710 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes #54305 from dongjoon-hyun/SPARK-55514. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: yangjie01 <yangjie01@baidu.com>
rpnkv
pushed a commit
to rpnkv/spark
that referenced
this pull request
Feb 18, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `ammonite` to 3.0.8 for Apache Spark 4.2.0. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.6 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.7 - com-lihaoyi/Ammonite#1706 - https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.8 - com-lihaoyi/Ammonite#1710 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes apache#54305 from dongjoon-hyun/SPARK-55514. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: yangjie01 <yangjie01@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #1684
This makes
repl.loadaccept "raw" sources starting withpackage. These are assumed to be standard Scala files, and are passed as-is to scalac.