Skip to content

[0.12] Add @deprecated annotation to bin-compat shims #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 0.12.x
Choose a base branch
from
Open

[0.12] Add @deprecated annotation to bin-compat shims #4728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f469ccd
Add `@deprecated("Use other overload instead", since = "0.12.9")` to …
lolgab Mar 14, 2025
157abfa
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main/util/src/mill/util/CoursierSupport.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ trait CoursierSupport {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependencies(
repositories: Seq[Repository],
deps: IterableOnce[Dependency],
Expand Down Expand Up @@ -434,6 +435,7 @@ trait CoursierSupport {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependenciesMetadataSafe(
repositories: Seq[Repository],
deps: IterableOnce[Dependency],
Expand All @@ -456,7 +458,8 @@ trait CoursierSupport {
Nil
)

// bin-compat shim
// bin-compat
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependenciesMetadataSafe(
repositories: Seq[Repository],
deps: IterableOnce[Dependency],
Expand Down
5 changes: 4 additions & 1 deletion main/util/src/mill/util/Jvm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ object Jvm extends CoursierSupport {
}

// bincompat shim
@deprecated("Use other overload instead", since = "0.12.9")
def runSubprocess(
mainClass: String,
classPath: Agg[os.Path],
Expand All @@ -357,6 +358,7 @@ object Jvm extends CoursierSupport {
None
)
// bincompat shim
@deprecated("Use other overload instead", since = "0.12.9")
def runSubprocess(
mainClass: String,
classPath: Agg[os.Path],
Expand Down Expand Up @@ -443,7 +445,8 @@ object Jvm extends CoursierSupport {
runSubprocess(args, envArgs, workingDir)
}

// bincompat shim
// bincompat
@deprecated("Use other overload instead", since = "0.12.9")
def runSubprocessWithBackgroundOutputs(
mainClass: String,
classPath: Agg[os.Path],
Expand Down
3 changes: 3 additions & 0 deletions scalalib/src/mill/scalalib/CoursierModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ trait CoursierModule extends mill.Module {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDeps(
deps: Task[Agg[BoundDep]],
sources: Boolean,
Expand Down Expand Up @@ -249,6 +250,7 @@ object CoursierModule {
) {

// bin-compat shim
@deprecated("Use other constructor instead", since = "0.12.9")
def this(
repositories: Seq[Repository],
bind: Dep => BoundDep,
Expand Down Expand Up @@ -291,6 +293,7 @@ object CoursierModule {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDeps[T: CoursierModule.Resolvable](
deps: IterableOnce[T],
sources: Boolean,
Expand Down
3 changes: 3 additions & 0 deletions scalalib/src/mill/scalalib/Lib.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ object Lib {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependenciesMetadataSafe(
repositories: Seq[Repository],
deps: IterableOnce[BoundDep],
Expand All @@ -103,6 +104,7 @@ object Lib {
)

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependenciesMetadataSafe(
repositories: Seq[Repository],
deps: IterableOnce[BoundDep],
Expand Down Expand Up @@ -163,6 +165,7 @@ object Lib {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def resolveDependencies(
repositories: Seq[Repository],
deps: IterableOnce[BoundDep],
Expand Down
1 change: 1 addition & 0 deletions scalalib/src/mill/scalalib/PublishModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ trait PublishModule extends JavaModule { outer =>
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def publishLocal(
localIvyRepo: String
): define.Command[Unit] =
Expand Down
2 changes: 2 additions & 0 deletions scalalib/src/mill/scalalib/publish/Ivy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ object Ivy {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def apply(
artifact: Artifact,
dependencies: Agg[Dependency],
Expand All @@ -98,6 +99,7 @@ object Ivy {
)

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def apply(
artifact: Artifact,
dependencies: Agg[Dependency],
Expand Down
1 change: 1 addition & 0 deletions scalalib/src/mill/scalalib/publish/LocalIvyPublisher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class LocalIvyPublisher(localIvyRepo: os.Path) {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def publishLocal(
jar: os.Path,
sourcesJar: os.Path,
Expand Down
1 change: 1 addition & 0 deletions scalalib/src/mill/scalalib/publish/LocalM2Publisher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class LocalM2Publisher(m2Repo: os.Path) {
}

// bin-compat shim
@deprecated("Use other overload instead", since = "0.12.9")
def publish(
jar: os.Path,
sourcesJar: os.Path,
Expand Down
Loading